[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-hackers
Subject:    Re: a few minor kldstat fixes
From:       Alexander Best <arundel () freebsd ! org>
Date:       2010-10-21 18:23:14
Message-ID: 20101021182314.GA16569 () freebsd ! org
[Download RAW message or body]

On Thu Oct 21 10, Garrett Cooper wrote:
> On Thu, Oct 21, 2010 at 10:46 AM, Alexander Best <arundel@freebsd.org> wrote:
> > this patch fixes the following issues:
> >
> > - unbreak 'kldstat -i 999 -v' output
> > - remove an unnecessary set of "{" and "}"
> > - change printfile() to blend into the overall style used in kldstat.c
> > - add a kldstat(8) entry to document the relationship between the "-i" and "-n" flags
> 
>     Might be better to say that the -i and -n options are mutually
> exclusive in the manpage, and have the args parser parse out those two
> cases and bail if both of them are set.

i don't think the current behavior should be changed. some people might have
something like 'kldstat -i X -n Y' in their scripts expect "-n Y" to override
"-i X", instead of having kldstat fail.

> Thanks!
> -Garrett

-- 
a13x
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
[prev in list] [next in list] [prev in thread] [next in thread]