[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-hackers
Subject:    Re: netstat -i Ierrs column, Is it total, or per second?
From:       John Baldwin <jhb () freebsd ! org>
Date:       2009-08-31 20:42:50
Message-ID: 200908311642.50866.jhb () freebsd ! org
[Download RAW message or body]

On Monday 31 August 2009 3:15:53 pm Andrew Brampton wrote:
> 2009/8/31 John Baldwin <jhb@freebsd.org>:
> > It should be total and it sounds like a bug in the device driver.  It 
looks
> > like ixgbe_update_stats_counters() overwrites the accumulated value of
> > if_ierrors:
> >
> >        /* Rx Errors */
> >        ifp->if_ierrors = total_missed_rx + adapter->stats.crcerrs +
> >                adapter->stats.rlec;
> >
> > It also increments if_ierrors in ixgbe_rxeof().  The driver should only do 
one
> > or the other, but probably not both.
> >
> > --
> > John Baldwin
> >
> 
> Thanks for your reply. I had wondered that, but looking at
> e1000/if_em.c it does a similar thing. However, a quick look at
> non-intel drivers and it seems others don't. So perhaps this is a
> problem across the intel drivers?
> 
> So anyway I spent my afternoon reading the ixgbe spec sheet and
> creating the attached patch, which hopefully fixes this problem. I
> will forward this patch to freebsd <at> intel.com unless someone can
> point me toward the maintainers email address, or should I just create
> a PR?

I cc'd him on my earlier reply (jfv@) so he should have seen your patch 
already.

-- 
John Baldwin
_______________________________________________
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"

[prev in list] [next in list] [prev in thread] [next in thread]