[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-fs
Subject:    Re: svn commit: r220241 - in stable/8/sys: kern sys
From:       Kostik Belousov <kostikbel () gmail ! com>
Date:       2011-07-24 18:56:29
Message-ID: 20110724185629.GD17489 () deviant ! kiev ! zoral ! com ! ua
[Download RAW message or body]


On Sun, Jul 24, 2011 at 02:50:44PM -0400, Benjamin Kaduk wrote:
> On Sun, 24 Jul 2011, Kostik Belousov wrote:
> 
> >On Sun, Jul 24, 2011 at 01:04:28PM -0400, Ben Kaduk wrote:
> >>[replying to -fs since that is where the original discussion of adding
> >>O_CLOEXEC occurred]
> >>
> >>On Fri, Apr 1, 2011 at 8:50 AM, Konstantin Belousov <kib@freebsd.org> 
> >>wrote:
> >>>Author: kib
> >>>Date: Fri Apr š1 12:50:29 2011
> >>>New Revision: 220241
> >>>URL: http://svn.freebsd.org/changeset/base/220241
> >>>
> >>>Log:
> >>>MFC r219999:
> >>>Add O_CLOEXEC flag to open(2) and fhopen(2).
> >>
> >>I saw mail go by on debian-bsd@lists.debian.org that the are going to
> >>pick up on these O_CLOEXEC definitions and export them, which included
> >>the comment:
> >>No O_SEARCH yet, since FreeBSD doesn't seem to implement it.
> >What do you mean by exporting them ?
> 
> Per http://lists.debian.org/debian-bsd/2011/07/msg00299.html , it is not 
> possible for them to use our sys/fcntl.h directly, so its contents must be 
> copied into a bits/fcntl.h that enters somehow into their framework.  (I 
> am not familiar with how this framework works.)
> 
> >
> >>
> >>Would there be any reason for us to support O_SEARCH?
> >>http://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html
> >>does not make it very clear to me whether we would want to....
> >
> >We do not support O_SEARCH because nobody implemented it yet.
> 
> Sure, but is it worth filing a PR as a reminder?

Without the patch ? No.

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]