[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-fs
Subject:    Re: zfs receive gives: internal error: Argument list too long
From:       Pawel Jakub Dawidek <pjd () freebsd ! org>
Date:       2009-12-16 21:46:21
Message-ID: 20091216214621.GA4217 () garage ! freebsd ! pl
[Download RAW message or body]


On Mon, Dec 14, 2009 at 10:39:26PM +0100, Martin Matuska wrote:
> I was unable to reproduce the panic (with 8.0-RELEASE-p1 + Pawel's patch
> or with my patch).
> 
> I can split my patch into two Opensolaris changesets - 8986, that is
> exactly pjd's patch. The other changeset is 7994.
> BUG ID 6764159: restore_object() makes a call that can block while
> having a tx open but not yet committed.
> 
> So to make life easier, I have split this and use 2 patches (that make
> together my old patch)
> a) 6764159_restore_blocking.patch
> b) zfs_recv_E2BIG.patch
> 
> I have also encountered a problem with recursive zfs snapshots of
> previsously transferred datasets.
> On many of my systems, zfs snapshot -r tank@xyz just did not work with
> the following error: zfs snapshot -r failed because filesystem was busy
> 
> Patch links:
> http://mfsbsd.vx.sk/patches/6764159_restore_blocking.patch
> http://mfsbsd.vx.sk/patches/6462803_zfs_snapshot_busy.patch
> http://people.freebsd.org/~pjd/patches/zfs_recv_E2BIG.patch
> 
> Related OpenSolaris links:
> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6462803 (zfs
> snapshot busy)
> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6764159
> (restore_object blocking)
> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6801979 (zfs
> receive E2BIG)
> 
> I am running all three patches on about 30-40 servers with 8 CPU cores,
> amd64 and intensive zfs snapshot -r, intense zfs send/receive operations
> for several days.
> No panics or other problems by now.

Martin, please go ahead and commit your patch.

Thank you for looking into this!

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd@FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]