[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-emulation
Subject:    [patch] comparison of u_long against < 0 in linux32_machdep.c
From:       Alexander Best <arundel () freebsd ! org>
Date:       2011-02-07 22:52:16
Message-ID: 20110207225216.GA62134 () freebsd ! org
[Download RAW message or body]

hi there,

this was reported by clang 2.9 (dev) as -Wtautological-compare warning. i think
clang is right, because linux_iopl_args.level is of type u_long.

cheers.
alex

-- 
a13x

["linux32_machdep.c.diff" (text/plain)]

Index: sys/amd64/linux32/linux32_machdep.c
===================================================================
--- sys/amd64/linux32/linux32_machdep.c	(revision 218413)
+++ sys/amd64/linux32/linux32_machdep.c	(working copy)
@@ -911,7 +911,7 @@
 {
 	int error;
 
-	if (args->level < 0 || args->level > 3)
+	if (args->level > 3)
 		return (EINVAL);
 	if ((error = priv_check(td, PRIV_IO)) != 0)
 		return (error);


_______________________________________________
freebsd-emulation@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-emulation
To unsubscribe, send any mail to "freebsd-emulation-unsubscribe@freebsd.org"


[prev in list] [next in list] [prev in thread] [next in thread]