[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-cvsweb
Subject:    Bug: CVSweb 3.0.4
From:       "Vlado Klimovsky" <klimovsky () iblsoft ! com>
Date:       2005-01-07 8:20:49
Message-ID: 20050107082051.0C563282BF0 () shodan ! ibl ! sk
[Download RAW message or body]


Hello,

there seems to be a bug in the 3.0.4 version of the CVSweb script. Please
see the spacedHtmlText() function, line 1585, which reads:

  1 while s/(.*)(\t+)/$1 . ' ' x (length($2) * $ts - length($1) % $ts)/e;

The problem is in the '(.*)' subexpression; by default the '*' match
specifier is greedy so the regular expression '(\t+)' will match the LAST
sequence of tabs on the string, not the first one. For this reason the tabs
are expanded into an incorrect number of spaces. I changed the line like
this:

  1 while s/(.*?)(\t+)/$1 . ' ' x (length($2) * $ts - length($1) % $ts)/e;

and the problem seems to be solved.

Regards,
Vlado Klimovsky


------------------------------------------------
Vladimir KLIMOVSKY (klimovsky@iblsoft.com)
IBL Software Engineering, http://www.iblsoft.com/
Mierova 103, 82105 Bratislava, Slovakia
Tel: +421 2 4342 7459, fax: +421 2 4342 7214

["smime.p7s" (application/x-pkcs7-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]