[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-current
Subject:    Re: head r355027 fails to (non-debug) build for: sys/arm/broadcom/bcm2835/bcm2835_sdhci.c:721:26:
From:       Kyle Evans <kevans () freebsd ! org>
Date:       2019-11-23 13:41:21
Message-ID: CACNAnaGHOoTtqbOOZ9oRcCLcSH_NE=L6fXBA2PtSGh1T19mXDA () mail ! gmail ! com
[Download RAW message or body]

On Sat, Nov 23, 2019 at 2:42 AM Mark Millard <marklmi@yahoo.com> wrote:
> 
> --- bcm2835_sdhci.o ---
> /usr/src/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c:721:26: error: unused variable \
> 'sc' [-Werror,-Wunused-variable] struct bcm_sdhci_softc *sc = \
> device_get_softc(slot->bus); ^
> 1 error generated.
> 
> This is because the sc is only used in:
> 
> KASSERT(sc->dmamap_seg_count == 0,
> ("data pending interrupt pushed through SDHCI framework"));
> 
> and this was a non-debug build: so the KASSERT did not use sc either.
> 
> 

Whoops, sorry about that! Fixed in r355031.

Thanks,

Kyle Evans
_______________________________________________
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"


[prev in list] [next in list] [prev in thread] [next in thread]