[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-current
Subject:    Re: panic: System call lstat returning with 1 locks held
From:       "Attilio Rao" <attilio () freebsd ! org>
Date:       2008-01-31 13:04:49
Message-ID: 3bbf2fe10801310504j486924bdm86e0436597a42b09 () mail ! gmail ! com
[Download RAW message or body]

2008/1/31, Yar Tikhiy <yar@comp.chem.msu.su>:
> On Thu, Jan 31, 2008 at 11:43:10AM +0100, Attilio Rao wrote:
>  >
>  > The assertion failing should not happen now.
>  > Could you please hand-add a check in _lockmgr_disown()
>  > (kern/kern_lock.c) in order to check for the panicstr before to call
>  > WITNESS? I cannot access to perforce now and produce a suitable diff,
>  > so you can just do this by hand:
>  >
>  > if (lkp->lk_lockholder == td) {
>  >         if (panicstr != NULL)
>  >                 WITNESS_UNLOCK(&lkp->lk_object, LOP_EXCLUSIVE, file, line);
>  >         td->td_locks--;
>  > }
>
>
> Shouldn't the test for panicstr be inverse: `panicstr == NULL'?
>  I guess we shouldn't call WITNESS when panicing, should we?
>  Sorry if I got it wrong.

Weee, you are right, sorry!

Attilio

-- 
Peace can only be achieved by understanding - A. Einstein
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
[prev in list] [next in list] [prev in thread] [next in thread]