[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-commits-all
Subject:    =?UTF-8?Q?Re:_svn_commit:_r367209_-_in_head:_contrib/elftoolchain/readel?= =?UTF-8?Q?f_usr.bin/reade
From:       "Brandon Bergren" <bdragon () FreeBSD ! org>
Date:       2020-10-31 21:30:53
Message-ID: 47495073-df63-404d-8a3b-af2241e12f9b () www ! fastmail ! com
[Download RAW message or body]

On Sat, Oct 31, 2020, at 3:03 PM, Brandon Bergren wrote:
> This appears to have broken the build on platforms with a 32 bit 
> size_t, given the current state of the tinderbox.
> 
> On Sat, Oct 31, 2020, at 10:27 AM, Ed Maste wrote:
> > Author: emaste
> > Date: Sat Oct 31 15:27:45 2020
> > New Revision: 367209
> > URL: https://svnweb.freebsd.org/changeset/base/367209
> > 
> 

This seems more correct to me:

It's not like it could have been larger than size_t anyway, since there is no way to \
malloc more than that anyway.

Index: contrib/elftoolchain/readelf/readelf.c
===================================================================
--- contrib/elftoolchain/readelf/readelf.c	(revision 367230)
+++ contrib/elftoolchain/readelf/readelf.c	(working copy)
@@ -6909,8 +6909,8 @@
  * Returns true if sucessful, false otherwise.
  */
 static bool decompress_section(struct section *s,
-    unsigned char *compressed_data_buffer, uint64_t compressed_size,
-    unsigned char **ret_buf, uint64_t *ret_sz)
+    unsigned char *compressed_data_buffer, size_t compressed_size,
+    unsigned char **ret_buf, size_t *ret_sz)
 {
 	GElf_Shdr sh;
 
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"


[prev in list] [next in list] [prev in thread] [next in thread]