[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-commits-all
Subject:    Re: svn commit: r344666 - head/tools/build/mk
From:       Kyle Evans <kevans () freebsd ! org>
Date:       2019-02-28 21:47:14
Message-ID: CACNAnaEFpXV4ooA8NY2-jJHKDKXHxc3SjcTPg6+c0s7qk+NCQg () mail ! gmail ! com
[Download RAW message or body]

On Thu, Feb 28, 2019 at 3:44 PM Enji Cooper <yaneurabeya@gmail.com> wrote:
>
>
> > On Feb 28, 2019, at 12:48 PM, Bryan Drewery <bdrewery@FreeBSD.org> wrote:
> >
> > Author: bdrewery
> > Date: Thu Feb 28 20:48:18 2019
> > New Revision: 344666
> > URL: https://svnweb.freebsd.org/changeset/base/344666
> >
> > Log:
> >  bsd.nls.mk isn't optional.
> >
> >  It is protected by MK_NLS.  If it should really be optional then
> >  it needs to be documented as such in share/mk/bsd.README and
> >  .sinclude used where needed.
> >
> >  This fixes a regression from r335011.
> >
> >  PR:          232527
> >  Submitted by:        jarrod@downtools.com.au
> >  Reported by: ktullavik@gmail.com
> >  MFC after:   3 days
>
>         Should bsd.{lib,prog}.mk instead be taught to ignore errors when including this file?
> Thanks!
> -Enji

If we actually conditionally installed it, sure- it was only removed
because of r335011, so it would go through an install/remove dance
between installworld and delete-old on WITHOUT_NLS systems.

If we're going to make it conditional on MK_NLS, it needs to actually
be conditional on MK_NLS the proper way along with an
s/.include/.sinclude/.
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
[prev in list] [next in list] [prev in thread] [next in thread]