[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-commits-all
Subject:    Re: svn commit: r303586 - head/bin/sh
From:       Alexey Dokuchaev <danfe () FreeBSD ! org>
Date:       2016-07-31 13:43:16
Message-ID: 20160731134316.GB85936 () FreeBSD ! org
[Download RAW message or body]

On Sun, Jul 31, 2016 at 01:11:34PM +0000, Jilles Tjoelker wrote:
> New Revision: 303586
> URL: https://svnweb.freebsd.org/changeset/base/303586
> 
> Log:
>   sh: Fix a clang warning.
>   
>   Submitted by:	bdrewery
> 
> Modified:
>   head/bin/sh/expand.c
> 
> Modified: head/bin/sh/expand.c
> ==============================================================================
> --- head/bin/sh/expand.c	Sun Jul 31 12:59:10 2016	(r303585)
> +++ head/bin/sh/expand.c	Sun Jul 31 13:11:34 2016	(r303586)
> @@ -473,7 +473,8 @@ expbackq(union node *cmd, int quoted, in
>  		if (--in.nleft < 0) {
>  			if (in.fd < 0)
>  				break;
> -			while ((i = read(in.fd, buf, sizeof buf)) < 0 && errno == EINTR);
> +			while ((i = read(in.fd, buf, sizeof buf)) < 0 && errno == EINTR)
> +				;

`continue;' would be even better; some tools might barf at stray semicolon.

./danfe
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
[prev in list] [next in list] [prev in thread] [next in thread]