[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-commits-all
Subject:    Re: cvs commit: src/sys/i386/i386 identcpu.c
From:       Mike Barcroft <mike () FreeBSD ! org>
Date:       2003-04-30 22:43:51
[Download RAW message or body]

Mark Murray <markm@FreeBSD.org> writes:
> markm       2003/04/30 05:23:58 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/i386/i386        identcpu.c 
>   Log:
>   Warns fixing. Protect against inappropriate linting, and mark
>   GCC-specific assemble code as such (in #ifdefs). Fix an easy
>   static variable warning while I'm here.
>   
>   Revision  Changes    Path
>   1.122     +8 -1      src/sys/i386/i386/identcpu.c

Is it really useful to #ifdef critical sections of code.  This thing
isn't going to compile without asm extentions from the compiler.  So
really you just turn compile errors into link error.  Not very helpful
IMO.

Also, you added an used #else clause near the top.

Best regards,
Mike Barcroft

[prev in list] [next in list] [prev in thread] [next in thread]