[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-bugs
Subject:    Re: kern/138004: commit references a PR
From:       dfilter () freebsd ! org (dfilter service)
Date:       2009-08-31 14:20:06
Message-ID: 200908311420.n7VEK6no067451 () freefall ! freebsd ! org
[Download RAW message or body]

The following reply was made to PR kern/138004; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/138004: commit references a PR
Date: Mon, 31 Aug 2009 14:14:00 +0000 (UTC)

 Author: jamie
 Date: Mon Aug 31 14:13:45 2009
 New Revision: 196699
 URL: http://svn.freebsd.org/changeset/base/196699
 
 Log:
   MFC r196592:
     Fix a LOR between allprison_lock and vnode locks by releasing
     allprison_lock before releasing a prison's root vnode.
   
   PR:		kern/138004
   Reviewed by:	kib
   Approved by:	re (rwatson), bz (mentor)
 
 Modified:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
   stable/8/sys/kern/kern_jail.c
 
 Modified: stable/8/sys/kern/kern_jail.c
 ==============================================================================
 --- stable/8/sys/kern/kern_jail.c	Mon Aug 31 14:06:59 2009	(r196698)
 +++ stable/8/sys/kern/kern_jail.c	Mon Aug 31 14:13:45 2009	(r196699)
 @@ -2453,7 +2453,7 @@ prison_deref(struct prison *pr, int flag
  		ppr = pr->pr_parent;
  		for (tpr = ppr; tpr != NULL; tpr = tpr->pr_parent)
  			tpr->pr_childcount--;
 -		sx_downgrade(&allprison_lock);
 +		sx_xunlock(&allprison_lock);
  
  #ifdef VIMAGE
  		if (pr->pr_vnet != ppr->pr_vnet)
 @@ -2479,7 +2479,7 @@ prison_deref(struct prison *pr, int flag
  		/* Removing a prison frees a reference on its parent. */
  		pr = ppr;
  		mtx_lock(&pr->pr_mtx);
 -		flags = PD_DEREF | PD_LIST_SLOCKED;
 +		flags = PD_DEREF;
  	}
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
_______________________________________________
freebsd-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"
[prev in list] [next in list] [prev in thread] [next in thread]