[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freebsd-arch
Subject:    Re: review: patch to restore VLAN kernel API in RELENG_6
From:       Gleb Smirnoff <glebius () freebsd ! org>
Date:       2006-01-13 18:02:13
Message-ID: 20060113180213.GH83922 () cell ! sick ! ru
[Download RAW message or body]

On Fri, Jan 13, 2006 at 05:52:12PM +0000, Xin LI wrote:
X> On Fri, Jan 13, 2006 at 08:20:49PM +0300, Gleb Smirnoff wrote:
X> > On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
X> > X> > +++ sys/dev/bge/if_bge.c	13 Jan 2006 17:04:31 -0000
X> > X> > @@ -2862,7 +2862,7 @@
X> > X> >  		 * attach that information to the packet.
X> > X> >  		 */
X> > X> >  		if (have_tag) {
X> > X> > -			VLAN_INPUT_TAG(ifp, m, vlan_tag);
X> > X> > +			VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
X> > X> 
X> > X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
X> > X> 
X> > X> Just my $0.02, though :-)
X> > 
X> > I really don't care. :)
X> 
X> Heh, my point was to make it possible to use the same name in
X> both drivers on RELENG_6 and 7.0, without having to call future
X> macros "foo_NEW_NG" or so =-)  Not really sure whether it is
X> conform to our tradition naming, though...

The correct macro takes 3 arguments, and the old one took 4. So
we can't make a code compilable with correct macro on both systems
without breaking API - using same macro.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
_______________________________________________
freebsd-arch@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"
[prev in list] [next in list] [prev in thread] [next in thread]