[prev in list] [next in list] [prev in thread] [next in thread]
List: fossil-users
Subject: Re: [fossil-users] Display of file content in the UI
From: Stephan Beal <sgbeal () googlemail ! com>
Date: 2013-05-04 3:25:36
Message-ID: CAKd4nAhnhYErJuv+t=5RJ2GY32BEUUg7rConQL4OkTmftU8fKA () mail ! gmail ! com
[Download RAW message or body]
A big fat +1 for that clever fix :-).
(sent from a mobile device - please excuse brevity, typos, and top-posting)
----- stephan beal
http://wanderinghorse.net
On May 4, 2013 3:48 AM, "Joel Bruick" <joel@joelface.com> wrote:
> Hi Mat,
>
> On 5/3/2013 6:40 PM, Matthias Toggweiler wrote:
>
> > Awesome, 5 minute reaction time on this mailing list. Thanks for the
> > fix, Stephan.
> >
>
> I am likewise amazed at how quickly answers/fixes often appear on this
> list.
>
> I came across this issue with HTML because I am designing a new
> > fossil skin, and I am aware that this little issue is irrelevant for
> > people who manage other types of source code.
> >
>
> This is a completely legitimate issue, and it had been bothering me for a
> while, too. Thanks for giving me the nudge I needed to look into fixing it.
> I've committed a fix to trunk here:
>
> http://www.fossil-scm.org/**index.html/info/63443f920b<http://www.fossil-scm.org/index.html/info/63443f920b>
>
> This is actually a lot simpler of a fix than your proposals. Instead of
> inlining the HTML file directly into the artifact page, it simply loads it
> from a sandboxed iframe. This lets us maintain the current functionality of
> actually displaying the rendered HTML but prevents interference from
> scripts/styles that may be present in the file.
>
> I've tested it in Firefox, Chrome, and IE on Windows. If anyone else finds
> any problems with it, please let me know.
> ______________________________**_________________
> fossil-users mailing list
> fossil-users@lists.fossil-scm.**org <fossil-users@lists.fossil-scm.org>
> http://lists.fossil-scm.org:**8080/cgi-bin/mailman/listinfo/**fossil-users<http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users>
>
[Attachment #3 (text/html)]
<p dir="ltr">A big fat +1 for that clever fix :-).</p>
<p dir="ltr">(sent from a mobile device - please excuse brevity, typos, and \
top-posting) <br>
----- stephan beal<br>
<a href="http://wanderinghorse.net">http://wanderinghorse.net</a></p>
<div class="gmail_quote">On May 4, 2013 3:48 AM, "Joel Bruick" <<a \
href="mailto:joel@joelface.com">joel@joelface.com</a>> wrote:<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi Mat,<br>
<br>
On 5/3/2013 6:40 PM, Matthias Toggweiler wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Awesome, 5 minute reaction time on this mailing list. Thanks \
for the<br> fix, Stephan.<br>
</blockquote>
<br>
I am likewise amazed at how quickly answers/fixes often appear on this list.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> I came across this issue with HTML because I am designing a \
new<br> fossil skin, and I am aware that this little issue is irrelevant for<br>
people who manage other types of source code.<br>
</blockquote>
<br>
This is a completely legitimate issue, and it had been bothering me for a while, too. \
Thanks for giving me the nudge I needed to look into fixing it. I've committed a \
fix to trunk here:<br> <br>
<a href="http://www.fossil-scm.org/index.html/info/63443f920b" \
target="_blank">http://www.fossil-scm.org/<u></u>index.html/info/63443f920b</a><br> \
<br> This is actually a lot simpler of a fix than your proposals. Instead of inlining \
the HTML file directly into the artifact page, it simply loads it from a sandboxed \
iframe. This lets us maintain the current functionality of actually displaying the \
rendered HTML but prevents interference from scripts/styles that may be present in \
the file.<br>
<br>
I've tested it in Firefox, Chrome, and IE on Windows. If anyone else finds any \
problems with it, please let me know.<br> \
______________________________<u></u>_________________<br> fossil-users mailing \
list<br> <a href="mailto:fossil-users@lists.fossil-scm.org" \
target="_blank">fossil-users@lists.fossil-scm.<u></u>org</a><br> <a \
href="http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users" \
target="_blank">http://lists.fossil-scm.org:<u></u>8080/cgi-bin/mailman/listinfo/<u></u>fossil-users</a><br>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]