[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fossil-dev
Subject:    Re: [fossil-dev] diff crash - broken repo?
From:       Stephan Beal <sgbeal () googlemail ! com>
Date:       2013-09-15 8:11:21
Message-ID: CAKd4nAiAA7mWT5sdzji4-OvLrvSPD9aGdLgR6Hh92Tr0g6VLaw () mail ! gmail ! com
[Download RAW message or body]

On Sat, Sep 14, 2013 at 11:44 PM, Jan Danielsson <jan.m.danielsson@gmail.com
> wrote:

> 58        sz = strlen(zUuid);
> (gdb) list
>

strlen() doesn't like a NULL string and it being passed one.

i unfortunately cannot reproduce this. Can you post your repo somewhere?


>    diff_manifest_entry() assumes that pFrom->zUuid is valid, which makes
> me think that something is inconsistent in my repository. And the fact
>

It is unlikely that something is inconsistent because before Fossil commits
a transaction it tries to read back what would be committed. It's more
likely that this is a corner case or a downright bug.


>    I'm currently not curious enough to spend more time digging around in
> the repository, but if anyone is interested and wants me to do some kind
> of post-mortem analysis, let me know.
>

If you can post your repo i'll take a look at it.


-- 
----- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal

[Attachment #3 (text/html)]

<div dir="ltr">On Sat, Sep 14, 2013 at 11:44 PM, Jan Danielsson <span \
dir="ltr">&lt;<a href="mailto:jan.m.danielsson@gmail.com" \
target="_blank">jan.m.danielsson@gmail.com</a>&gt;</span> wrote:<br><div \
class="gmail_extra"><div class="gmail_quote"> <blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">58 \
sz = strlen(zUuid);<br> (gdb) list<br></blockquote><div><br></div><div>strlen() \
doesn&#39;t like a NULL string and it being passed one.</div><div><br></div><div>i \
unfortunately cannot reproduce this. Can you post your repo somewhere?</div><div>  \
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> \
diff_manifest_entry() assumes that pFrom-&gt;zUuid is valid, which makes<br>

me think that something is inconsistent in my repository. And the \
fact<br></blockquote><div><br></div><div>It is unlikely that something is \
inconsistent because before Fossil commits a transaction it tries to read back what \
would be committed. It&#39;s more likely that this is a corner case or a downright \
bug.</div> <div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> \
I&#39;m currently not curious enough to spend more time digging around in<br>

the repository, but if anyone is interested and wants me to do some kind<br>
of post-mortem analysis, let me know.<br></blockquote><div><br></div><div>If you can \
post your repo i&#39;ll take a look at \
it.</div><div><br></div></div><div><br></div>-- <br>----- stephan beal<br><a \
href="http://wanderinghorse.net/home/stephan/" \
target="_blank">http://wanderinghorse.net/home/stephan/</a><div> <a \
href="http://gplus.to/sgbeal" target="_blank">http://gplus.to/sgbeal</a></div> \
</div></div>



[prev in list] [next in list] [prev in thread] [next in thread]