[prev in list] [next in list] [prev in thread] [next in thread] 

List:       forrest-svn
Subject:    svn commit: r436700 - in /forrest/trunk:
From:       crossley () apache ! org
Date:       2006-08-25 7:49:07
Message-ID: 20060825074908.217A81A981A () eris ! apache ! org
[Download RAW message or body]

Author: crossley
Date: Fri Aug 25 00:49:06 2006
New Revision: 436700

URL: http://svn.apache.org/viewvc?rev=436700&view=rev
Log:
When using html as source, the "a" elements were not rendered properly if both
@href and @name attributes. A side-effect of this fix is that now all other
attributes such as @title or @target are copied over.
Also removed the automated generation of @id attributes from @name attributes,
which can lead to invalid IDs and other confusion.
fixes-bug="FOR-448" due-to="Jim Dixon"

Modified:
    forrest/trunk/main/webapp/resources/stylesheets/html-to-document.xsl
    forrest/trunk/site-author/status.xml

Modified: forrest/trunk/main/webapp/resources/stylesheets/html-to-document.xsl
URL: http://svn.apache.org/viewvc/forrest/trunk/main/webapp/resources/stylesheets/html-to-document.xsl?rev=436700&r1=436699&r2=436700&view=diff
 ==============================================================================
--- forrest/trunk/main/webapp/resources/stylesheets/html-to-document.xsl (original)
+++ forrest/trunk/main/webapp/resources/stylesheets/html-to-document.xsl Fri Aug 25 \
00:49:06 2006 @@ -174,21 +174,14 @@
        </xsl:choose>
     </xsl:template>
 
-  
     <!-- convert a to link -->
     <xsl:template match="a">
-      <xsl:if test="@name">
-        <!-- Attach an id to the current node -->
-        <xsl:attribute name="id"><xsl:value-of select="translate(@name, ' $', \
'__')"/></xsl:attribute> +      <link>
+        <xsl:copy-of select="@*"/>
         <xsl:apply-templates/>
-      </xsl:if>
-      <xsl:if test="@href">
-        <link href="{@href}">
-          <xsl:apply-templates/>
-        </link>
-      </xsl:if>
+      </link>
     </xsl:template>
-    
+
     <xsl:template match="@valign | @align"/>
         
     <xsl:template match="center">

Modified: forrest/trunk/site-author/status.xml
URL: http://svn.apache.org/viewvc/forrest/trunk/site-author/status.xml?rev=436700&r1=436699&r2=436700&view=diff
 ==============================================================================
--- forrest/trunk/site-author/status.xml (original)
+++ forrest/trunk/site-author/status.xml Fri Aug 25 00:49:06 2006
@@ -140,6 +140,13 @@
         <link href="site:v0.80//upgrading_08">upgrading to v0.8</link>
       </action>
 <!-- 2006-08 -->
+      <action context="code" type="fix" dev="DC" fixes-bug="FOR-448" due-to="Jim \
Dixon"> +        When using html as source, the "a" elements were not rendered \
properly if both +        @href and @name attributes. A side-effect of this fix is \
that now all other +        attributes such as @title or @target are copied over.
+        Also removed the automated generation of @id attributes from @name \
attributes, +        which can lead to invalid IDs and other confusion.
+      </action>
       <action type="update" context="docs" dev="TS">
         <strong>FOR-920</strong> - Addings notes how to
         <link href="site:v0.80//upgrading_08">update</link> the different module \
calls in


[prev in list] [next in list] [prev in thread] [next in thread]