[prev in list] [next in list] [prev in thread] [next in thread]
List: forgerock-openam-commit
Subject: [CommitOpenAM] [16186] trunk/policy-agents/source/process.c: CR8432, OpenAM-6928, Not Enforced URLs
From: noreply () forgerock ! org
Date: 2015-10-30 10:01:07
Message-ID: 20151030100107.16FA620C9D () sources2 ! internal ! forgerock ! com
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[16186] trunk/policy-agents/source/process.c: CR8432, OpenAM-6928, Not \
Enforced URLs Audit Log now also contains user name</title> </head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://sources.forgerock.org/changelog/openam/?cs=16186">16186</a></dd> \
<dt>Author</dt> <dd>spareyc</dd> <dt>Date</dt> <dd>2015-10-30 10:01:06 +0000 (Fri, 30 \
Oct 2015)</dd> </dl>
<h3>Log Message</h3>
<pre>CR8432, <a href="https://bugster.forgerock.org/jira/browse/OPENAM-6928">OpenAM-6928</a>, \
Not Enforced URLs Audit Log now also contains user name</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkpolicyagentssourceprocessc">trunk/policy-agents/source/process.c</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#trunkpolicyagentssourceprocessc">trunk/policy-agents/source/process.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkpolicyagentssourceprocessc"></a>
<div class="modfile"><h4>Modified: trunk/policy-agents/source/process.c (16185 => \
16186)</h4> <pre class="diff"><span>
<span class="info">--- trunk/policy-agents/source/process.c 2015-10-30 09:54:12 UTC \
(rev 16185)
+++ trunk/policy-agents/source/process.c 2015-10-30 10:01:06 UTC (rev 16186)
</span><span class="lines">@@ -1828,13 +1828,14 @@
</span><span class="cx"> set_user_attributes(r);
</span><span class="cx">
</span><span class="cx"> if (AM_BITMASK_CHECK(r->conf->audit_level, \
AM_LOG_LEVEL_AUDIT_ALLOW)) { </span><ins>+ const char *user_name_log = \
ISVALID(r->user) ? r->user : r->user_temp; </ins><span class="cx"> \
AM_LOG_AUDIT(r->instance_id, AUDIT_ALLOW_USER_MESSAGE, </span><del>- \
LOGEMPTY(r->user), LOGEMPTY(r->client_ip), LOGEMPTY(r->normalized_url)); \
</del><ins>+ LOGEMPTY(user_name_log), \
LOGEMPTY(r->client_ip), LOGEMPTY(r->normalized_url)); </ins><span class="cx"> \
if (AM_BITMASK_CHECK(r->conf->audit_level, AM_LOG_LEVEL_AUDIT_REMOTE)) { \
</span><span class="cx"> int audit_status = \
am_add_remote_audit_entry(r->instance_id, r->conf->token, </span><span \
class="cx"> r->session_info.si, \
r->conf->audit_file_remote, </span><span class="cx"> \
r->token, AUDIT_ALLOW_USER_MESSAGE, </span><del>- \
LOGEMPTY(r->user), LOGEMPTY(r->client_ip), LOGEMPTY(r->normalized_url)); \
</del><ins>+ LOGEMPTY(user_name_log), \
LOGEMPTY(r->client_ip), LOGEMPTY(r->normalized_url)); </ins><span class="cx"> \
if (audit_status != AM_SUCCESS) { </span><span class="cx"> \
AM_LOG_ERROR(r->instance_id, "%s failed to store remote audit log message \
(%s)", </span><span class="cx"> thisfunc, \
am_strerror(audit_status)); </span><span class="cx">Property changes on: \
trunk/policy-agents/source/process.c </span><span \
class="cx">___________________________________________________________________ \
</span></span></pre></div> <a id="svnmergeinfo"></a>
<div class="addfile"><h4>Added: svn:mergeinfo</h4></div>
<span class="cx">/branches/AME-2526-SFO-between-sites/policy-agents/source/process.c:7510-8258
</span><span class="cx">/branches/AME-3423/policy-agents/source/process.c:10105-10414
</span><span class="cx">/branches/AME-3612-pcunnington/policy-agents/source/process.c:9534-9723
</span><span class="cx">/branches/AME-3719/policy-agents/source/process.c:9517-9879
</span><span class="cx">/branches/AME-4378/policy-agents/source/process.c:10443-10621
</span><span class="cx">/branches/AME-4460_AME-4459/policy-agents/source/process.c:10437-10535
</span><span class="cx">/branches/AME-4547/policy-agents/source/process.c:10585-10783
</span><span class="cx">/branches/AME-4595/policy-agents/source/process.c:10581-10789
</span><span class="cx">/branches/AME-4609/policy-agents/source/process.c:10678-10949
</span><span class="cx">/branches/AME-4616/policy-agents/source/process.c:10652-10817
</span><span class="cx">/branches/AME-4638/policy-agents/source/process.c:10869-11050
</span><span class="cx">/branches/AME-5023/policy-agents/source/process.c:11070-11123
</span><span class="cx">/branches/AME-5568-stateless-sessions/policy-agents/source/process.c:12629-13078
</span><span class="cx">/branches/AME-6128_and_AME-6129_JSONify_attributes_for_OATH/policy-agents/source/process.c:13797-13866
</span><span class="cx">/branches/AME-6128_and_AME-6129_new_user_attributes_for_OATH/policy-agents/source/process.c:13602-13794
</span><span class="cx">/branches/AME-6274-rwapshott-unit-test-changes/policy-agents/source/process.c:15236-15433
</span><span class="cx">/branches/AME-6369/policy-agents/source/process.c:13289-13686
</span><span class="cx">/branches/AME-6796/policy-agents/source/process.c:13716-13732
</span><span class="cx">/branches/AME-6837/policy-agents/source/process.c:15695-15705
</span><span class="cx">/branches/AME-7509/policy-agents/source/process.c:14559-14630
</span><span class="cx">/branches/AME-7515/policy-agents/source/process.c:14510-14556
</span><span class="cx">/branches/AME-7718-adding-removing-server-instances/policy-agents/source/process.c:14729-15875
</span><span class="cx">/branches/AME-7904/policy-agents/source/process.c:15062-15373
</span><span class="cx">/branches/IIS7PostData/policy-agents/source/process.c:224-261
</span><span class="cx">/branches/OPENAM-2961-forgot-password-404/policy-agents/source/process.c:8322-8362
</span><span class="cx">/branches/OPENAM-3097-sessions-not-deleted/policy-agents/source/process.c:6910-6946
</span><span class="cx">/branches/OPENAM-3283-CTS-thread-exceptions/policy-agents/source/process.c:7270-7369
</span><span class="cx">/branches/OPENAM-3425-class-cast-exception/policy-agents/source/process.c:8333-8359
</span><span class="cx">/branches/OPENAM-3782-forgotten-password-changes/policy-agents/source/process.c:8747-8835
</span><span class="cx">/branches/OPENAM-4384-ssoadm-classpath/policy-agents/source/process.c:10263-10264
</span><span class="cx">/branches/OPENAM-4394/policy-agents/source/process.c:11059-11099
</span><span class="cx">/branches/OPENAM-4775-REST-endpoint-malformed-3/policy-agents/source/process.c:11322-11331
</span><span class="cx">/branches/OPENAM-5269/policy-agents/source/process.c:11838-11851
</span><span class="cx">/branches/OPENAM-5970_trim_unused_qrcode_references/policy-agents/source/process.c:13756-13770
</span><span class="cx">/branches/OPENAM-6326-ssoadm-classpath/policy-agents/source/process.c:14839-14844
</span><span class="cx">/branches/OPENAM-OPENAM-3528-client-side-session-validation/policy-agents/source/process.c:7834-7844
</span><span class="cx">/branches/ame4103/policy-agents/source/process.c:9979,9981,9998,10000,10002,10007-10008,10016,10018,10038
</span><span class="cx">/branches/ame4272/policy-agents/source/process.c:10073-10101
</span><span class="cx">/branches/andy-ame-2227-v2/policy-agents/source/process.c:7508-7697
</span><span class="cx">/branches/andy-ame1316-connectionfactory/policy-agents/source/process.c:5311-5328
</span><span class="cx">/branches/andy-cts-connection-pool/policy-agents/source/process.c:7098-7175
</span><span class="cx">/branches/andy-openam-2654/policy-agents/source/process.c:6872-6911
</span><span class="cx">/branches/andy-openam-2880/policy-agents/source/process.c:6451-6503
</span><span class="cx">/branches/andy-openam-2907/policy-agents/source/process.c:6531-6534
</span><span class="cx">/branches/andy-openam-3006/policy-agents/source/process.c:6709-6749
</span><span class="cx">/branches/andy-openam-3063/policy-agents/source/process.c:6927-6948
</span><span class="cx">/branches/andy-openam-3193/policy-agents/source/process.c:7124-7128
</span><span class="cx">/branches/andy-openam-3248/policy-agents/source/process.c:7171-7715
</span><span class="cx">/branches/andy-openam2743/policy-agents/source/process.c:6372-6439
</span><span class="cx">/branches/andy-openam2744/policy-agents/source/process.c:6347-6367
</span><span class="cx">/branches/andyAme2972/policy-agents/source/process.c:8270-8318
</span><span class="cx">/branches/andyAme3196/policy-agents/source/process.c:8853-9084
</span><span class="cx">/branches/andyAme5550/policy-agents/source/process.c:13493-13515
</span><span class="cx">/branches/andyOpenam1708/policy-agents/source/process.c:5576-5592
</span><span class="cx">/branches/andyOpenam2140/policy-agents/source/process.c:7819-7862
</span><span class="cx">/branches/andyOpenam2373/policy-agents/source/process.c:5600-5706
</span><span class="cx">/branches/andyOpenam2525/policy-agents/source/process.c:5601-5733
</span><span class="cx">/branches/andyOpenam3509/policy-agents/source/process.c:7881-7963
</span><span class="cx">/branches/andyOpenam3638/policy-agents/source/process.c:8094-8172
</span><span class="cx">/branches/andyOpenam3969/policy-agents/source/process.c:10453-10977
</span><span class="cx">/branches/andyPolicyCrest/policy-agents/source/process.c:8295-8813
</span><span class="cx">/branches/apforrest-ame1316/policy-agents/source/process.c:4881-5305
</span><span class="cx">/branches/contextualAuthz/policy-agents/source/process.c:12734-12787
</span><span class="cx">/branches/curieResourceTypes/policy-agents/source/process.c:12286-12669
</span><span class="cx">/branches/maven_merge/policy-agents/source/process.c:2556-3124
</span><span class="cx">/branches/openam-3049-cts-reaper-connection-usage/policy-agents/source/process.c:6658-6745
</span><span class="cx">/branches/openam-3053-cts-tab-exception/policy-agents/source/process.c:6672-6721
</span><span class="cx">/branches/openam-3072-cts-configuration/policy-agents/source/process.c:6691-6714
</span><span class="cx">/branches/openam-3092-store-mode-error/policy-agents/source/process.c:6729-6733
</span><span class="cx">/branches/openam-3110-create-or-update-bug/policy-agents/source/process.c:6767-6804
</span><span class="cx">/branches/openam2742-andy/policy-agents/source/process.c:6266-6323
</span><span class="cx">/branches/pcunnington-AME-3115-refactor/policy-agents/source/process.c:8348-8473
</span><span class="cx">/branches/pcunnington-AME-3158/policy-agents/source/process.c:8476-8577
</span><span class="cx">/branches/pcunnington-AME-350/policy-agents/source/process.c:4165-4344
</span><span class="cx">/branches/pcunnington-ame-344/policy-agents/source/process.c:4651-5199
</span><span class="cx">/branches/pcunnington-oauth2/policy-agents/source/process.c:8710-8793
</span><span class="cx">/branches/phcunnington-AME-3114/policy-agents/source/process.c:8314-8341
</span><span class="cx">/branches/policyimprovements/policy-agents/source/process.c:5513-5515
</span><span class="cx">/branches/referralsWithoutApplications/policy-agents/source/process.c:11071-11119
</span><span class="cx">/branches/rwapshott-AME-1739/policy-agents/source/process.c:5331-5353
</span><span class="cx">/branches/rwapshott-AME-215/policy-agents/source/process.c:4091-4155
</span><span class="cx">/branches/rwapshott-AME-257/policy-agents/source/process.c:4047-4126
</span><span class="cx">/branches/rwapshott-AME-804/policy-agents/source/process.c:4267-5404
</span><span class="cx">/branches/rwapshott-ame-2160-session-size/policy-agents/source/process.c:6086-6319
</span><span class="cx">/branches/rwapshott-openam-2198-session-resource-protection/policy-agents/source/process.c:5628-5824
</span><span class="cx">/branches/rwapshott-openam-2526/policy-agents/source/process.c:5442-5484
</span><span class="cx">/branches/rwapshott-openam-2716-cts-invalid-chars/policy-agents/source/process.c:6170-6194
</span><span class="cx">/branches/twoStepVerification/policy-agents/source/process.c:13994-14047
</span><span class="cx">/branches/ui-temp/policy-agents/source/process.c:15173-15278
</span><span class="cx">/fr-branches/11.0.x/policy-agents/source/process.c:12232
</span><span class="cx">/fr-branches/Agents-4.0.0/source/process.c:16185
</span></div>
<div id="footer">Copyright (c) by ForgeRock. All rights reserved.</div>
</body>
</html>
_______________________________________________
CommitOpenAM mailing list
CommitOpenAM@forgerock.org
https://lists.forgerock.org/mailman/listinfo/commitopenam
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic