[prev in list] [next in list] [prev in thread] [next in thread]
List: forgerock-commons
Subject: [Commons] [2128] forgerock-ui/trunk: CR-3747 - CUI-14 - Fixing the behavior of validateAllFields
From: noreply () forgerock ! org
Date: 2014-06-18 18:10:02
Message-ID: 20140618181002.43DFA422C7 () sources ! internal ! forgerock ! com
[Download RAW message or body]
[Attachment #2 (text/html)]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2128] forgerock-ui/trunk: CR-3747 - CUI-14 - Fixing the behavior of \
validateAllFields</title> </head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt; } #msg dl a { font-weight: \
bold} #msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
.info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a \
href="http://sources.forgerock.org/changelog/commons/?cs=2128">2128</a></dd> \
<dt>Author</dt> <dd>jake.feasel</dd> <dt>Date</dt> <dd>2014-06-18 19:10:02 +0100 \
(Wed, 18 Jun 2014)</dd> </dl>
<h3>Log Message</h3>
<pre>CR-3747 - CUI-14 - Fixing the behavior of validateAllFields</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#forgerockuitrunkforgerockuicommonssrcmainjsorgforgerockcommonsuicommonma \
inValidatorsManagerjs">forgerock-ui/trunk/forgerock-ui-commons/src/main/js/org/forgerock/commons/ui/common/main/ValidatorsManager.js</a></li>
<li><a href="#forgerockuitrunkforgerockuimocksrcmainjsorgforgerockmockuiuserUserRegis \
trationViewjs">forgerock-ui/trunk/forgerock-ui-mock/src/main/js/org/forgerock/mock/ui/user/UserRegistrationView.js</a></li>
<li><a href="#forgerockuitrunkforgerockuimocksrctestqunitmockjs">forgerock-ui/trunk/forgerock-ui-mock/src/test/qunit/mock.js</a></li>
<li><a href="#forgerockuitrunkpomxml">forgerock-ui/trunk/pom.xml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="forgerockuitrunkforgerockuicommonssrcmainjsorgforgerockcommonsuicommonmainValidatorsManagerjs"></a>
<div class="modfile"><h4>Modified: \
forgerock-ui/trunk/forgerock-ui-commons/src/main/js/org/forgerock/commons/ui/common/main/ValidatorsManager.js \
(2127 => 2128)</h4> <pre class="diff"><span>
<span class="info">--- \
forgerock-ui/trunk/forgerock-ui-commons/src/main/js/org/forgerock/commons/ui/common/main/ValidatorsManager.js 2014-06-17 \
13:20:53 UTC (rev 2127)
+++ forgerock-ui/trunk/forgerock-ui-commons/src/main/js/org/forgerock/commons/ui/common/main/ValidatorsManager.js 2014-06-18 \
18:10:02 UTC (rev 2128) </span><span class="lines">@@ -254,18 +254,10 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> obj.validateAllFields = function(el) {
</span><del>- _.each(el.find(":input"), function(input){
- input = el.find(input);
- var event = input.attr('data-validator-event');
-
- if(event) {
- _.each(event.split(/\s+/), function (e) {
- input.trigger(e);
- });
- } else {
- input.trigger("change");
- }
- });
</del><ins>+ // we bind "blur" as a validation event to all input \
fields, to this is enough to trigger the event. + // Also has the nice effect \
of not changing the state of the input, as was sometimes happening for different + \
// input types (notably, checkboxes with change events). + \
el.find(":input").trigger("blur"); </ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> obj.formValidated = function(el) {
</span></span></pre></div>
<a id="forgerockuitrunkforgerockuimocksrcmainjsorgforgerockmockuiuserUserRegistrationViewjs"></a>
<div class="modfile"><h4>Modified: \
forgerock-ui/trunk/forgerock-ui-mock/src/main/js/org/forgerock/mock/ui/user/UserRegistrationView.js \
(2127 => 2128)</h4> <pre class="diff"><span>
<span class="info">--- \
forgerock-ui/trunk/forgerock-ui-mock/src/main/js/org/forgerock/mock/ui/user/UserRegistrationView.js 2014-06-17 \
13:20:53 UTC (rev 2127)
+++ forgerock-ui/trunk/forgerock-ui-mock/src/main/js/org/forgerock/mock/ui/user/UserRegistrationView.js 2014-06-18 \
18:10:02 UTC (rev 2128) </span><span class="lines">@@ -88,6 +88,7 @@
</span><span class="cx">
</span><span class="cx"> this.parentRender(function () {
</span><span class="cx"> validatorsManager.bindValidators(this.$el, \
userDelegate.serviceUrl + "/*", _.bind(function () { </span><ins>+ \
validatorsManager.validateAllFields(this.$el); </ins><span class="cx"> \
this.unlock(); </span><span class="cx"> if (callback) {
</span><span class="cx"> callback();
</span></span></pre></div>
<a id="forgerockuitrunkforgerockuimocksrctestqunitmockjs"></a>
<div class="modfile"><h4>Modified: \
forgerock-ui/trunk/forgerock-ui-mock/src/test/qunit/mock.js (2127 => 2128)</h4> <pre \
class="diff"><span> <span class="info">--- \
forgerock-ui/trunk/forgerock-ui-mock/src/test/qunit/mock.js 2014-06-17 13:20:53 UTC \
(rev 2127)
+++ forgerock-ui/trunk/forgerock-ui-mock/src/test/qunit/mock.js 2014-06-18 18:10:02 \
UTC (rev 2128) </span><span class="lines">@@ -127,11 +127,13 @@
</span><span class="cx"> testStatusAttr(mail, 'error');
</span><span class="cx"> testStatusAttr(givenName, 'error');
</span><span class="cx"> testStatusAttr(lastName, 'error');
</span><del>- testStatusAttr(phone, 'error');
</del><ins>+ testStatusAttr(phone, 'ok'); // phone is optional
</ins><span class="cx"> testStatusAttr(pwd, 'error');
</span><span class="cx"> testStatusAttr(pwdConfirm, 'error');
</span><span class="cx"> testStatusAttr(terms, 'error');
</span><span class="cx">
</span><ins>+ QUnit.ok(!terms.is(':checked'), 'Terms of use not \
checked by default'); +
</ins><span class="cx"> // password
</span><span class="cx"> testFieldRule(pwd, 'abc', pwdRequired, \
pwdRequired.attr('data-for-req'), 'ok'); </span><span class="cx"> \
testFieldRule(pwd, 'abc1', pwdContainsNumbers, \
pwdContainsNumbers.attr('data-for-req'), 'ok'); </span></span></pre></div>
<a id="forgerockuitrunkpomxml"></a>
<div class="modfile"><h4>Modified: forgerock-ui/trunk/pom.xml (2127 => 2128)</h4>
<pre class="diff"><span>
<span class="info">--- forgerock-ui/trunk/pom.xml 2014-06-17 13:20:53 UTC (rev 2127)
+++ forgerock-ui/trunk/pom.xml 2014-06-18 18:10:02 UTC (rev 2128)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> </parent>
</span><span class="cx">
</span><span class="cx"> <properties>
</span><del>- \
<forgerock-ui.version>1.0.15-SNAPSHOT</forgerock-ui.version> </del><ins>+ \
<forgerock-ui.version>1.0.16-SNAPSHOT</forgerock-ui.version> </ins><span \
class="cx"> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</span><span class="cx"> </properties>
</span><span class="cx">
</span></span></pre>
</div>
</div>
<div id="footer">Copyright (c) by ForgeRock. All rights reserved.</div>
</body>
</html>
_______________________________________________
Commons mailing list
Commons@forgerock.org
https://lists.forgerock.org/mailman/listinfo/commons
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic