[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fop-dev
Subject:    [jira] [Updated] (FOP-3087) PDFTranscoder fails to auto-detect system fonts by default
From:       Julian_Müller_(Jira) <jira () apache ! org>
Date:       2022-08-10 20:59:38
Message-ID: JIRA.13476245.1660165348000.148487.1660165440004 () Atlassian ! JIRA
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/FOP-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Julian Müller updated FOP-3087:
-------------------------------
    Description: 
Contrary to the documentation, the PDFTranscoder fails to auto-detect system fonts by \
default, and also does not honor transcoding hint KEY_AUTO_FONTS = true.

This is because the implicitly built configuration is not set up correctly. Line 163
{code:java}
                       c.addChild(fonts); {code}
in AbstractFOPTranscoder needs to be moved after line 165, which is
{code:java}
                       fonts.addChild(autodetect); {code}
  
A simple workaround to this problem is to explicitly pass a correctly set up \
configuration to PDFTranscoder, however, it would be preferable if PDFTranscoder \
would just honor its contract.

I think this bug was introduced by FOP-2733, due to a subtle difference in Avalon's \
configuration package and its replacement. Avalon's configuration package allowed the \
addition of children in any order, but the new FOP configuration package adds copies \
instead of the original children, so the configuration tree needs to be built from \
the leaves to the root node. Currently, the code in AbstractFOPTranscoder does not \
follow this new requirement and instead builds the configuration tree from the root \
to the leaf.

  was:
Contrary to the documentation, the PDFTranscoder fails to auto-detect system fonts by \
default, and also does not honor transcoding hint KEY_AUTO_FONTS = true.

This is because the implicitly built configuration is not set up correctly. Line 163
{code:java}
                       c.addChild(fonts); {code}
in AbstractFOPTranscoder needs to be moved after line 165, which is
{code:java}
                       fonts.addChild(autodetect); {code}
  
A simple workaround to this problem is to explicitly pass a correctly set up \
configuration to PDFTranscoder, however, it would be preferable if PDFTranscoder \
would just honor its contract.

I think this bug was introduced by FOP-2733, due to a subtle difference in Avalon's \
configuration package and its replacement. Avalon's configuration package allowed the \
addition of children in any order, but the new FOP configuration package adds copies \
instead of the original children, so the configuration tree needs to be built from \
the leaves to the root node. As of now, the code in AbstractFOPTranscoder does not \
follow this new requirement and instead builds the configuration tree from the root \
to the leaf.


> PDFTranscoder fails to auto-detect system fonts by default
> ----------------------------------------------------------
> 
> Key: FOP-3087
> URL: https://issues.apache.org/jira/browse/FOP-3087
> Project: FOP
> Issue Type: Bug
> Affects Versions: 2.5, 2.4, 2.6, 2.7
> Reporter: Julian Müller
> Priority: Minor
> 
> Contrary to the documentation, the PDFTranscoder fails to auto-detect system fonts \
> by default, and also does not honor transcoding hint KEY_AUTO_FONTS = true. This is \
> because the implicitly built configuration is not set up correctly. Line 163 \
> {code:java} c.addChild(fonts); {code}
> in AbstractFOPTranscoder needs to be moved after line 165, which is
> {code:java}
> fonts.addChild(autodetect); {code}
> 
> A simple workaround to this problem is to explicitly pass a correctly set up \
> configuration to PDFTranscoder, however, it would be preferable if PDFTranscoder \
> would just honor its contract. I think this bug was introduced by FOP-2733, due to \
> a subtle difference in Avalon's configuration package and its replacement. Avalon's \
> configuration package allowed the addition of children in any order, but the new \
> FOP configuration package adds copies instead of the original children, so the \
> configuration tree needs to be built from the leaves to the root node. Currently, \
> the code in AbstractFOPTranscoder does not follow this new requirement and instead \
> builds the configuration tree from the root to the leaf.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[prev in list] [next in list] [prev in thread] [next in thread]