[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fop-dev
Subject:    [jira] [Updated] (FOP-1760) [PATCH] FOP doesn't support change bar generation
From:       Jan_Tošovský_(JIRA) <jira () apache ! org>
Date:       2015-06-19 20:15:00
Message-ID: JIRA.12622149.1263475575000.123305.1434744900785 () Atlassian ! JIRA
[Download RAW message or body]


     [ https://issues.apache.org/jira/browse/FOP-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Jan Tošovský updated FOP-1760:
------------------------------
    Attachment: patch_against_rev_1686494_2015-06-19.patch
                changebars.pdf
                changebars.fo

Updated patch with a test document. Please note some examples in FO file are \
commented (see the reason below).

The original patch solves IMO majority of real cases. There is a room for further \
improvements, but hard to say how much effort is needed:

Issues:
(1) When dotted or dashed bars are used, change bars are drawn, but the text after \
change-bar-begin tag disappear (and no error is shown). Surprisingly it works for \
more obscure styles like ridge or groove.

(2) Overlapping bars are not supported. I would at least expect a warning (not \
supported yet) instead of exception.

(3) change-bar-placement inside/outside renders bars IMO shifted. I would expect them \
in the position start/end.

(4) Surrounding <fo:table-cell> by change bars seems to be unsupported (Class Cast \
Exception). Surrounding fo:table-row and surprisingly also entire \
fo:table-header/body/footer works fine.

(5) clone method in BodyArea class looks suspicious to me ;-)


> [PATCH] FOP doesn't support change bar generation
> -------------------------------------------------
> 
> Key: FOP-1760
> URL: https://issues.apache.org/jira/browse/FOP-1760
> Project: FOP
> Issue Type: Bug
> Components: unqualified
> Affects Versions: trunk
> Environment: Operating System: All
> Platform: All
> Reporter: Stephan Thesing
> Attachments: change-bars.fo, change_bars_diff.txt, changebar.diff, \
> changebar_20110308.diff, changebars.fo, changebars.pdf, changebars_20110512.diff, \
> diff_2010_03_06.txt, fop_20120507.diff, fop_changebars_20120506.diff, \
> patch_against_rev_1686494_2015-06-19.patch 
> 
> In order to produce change bars along the columns for changed contents,
> FO supports the fo:change-bar-begin and fo:change-bar-end elements.
> These are not supported by FOP.
> Support for change bars should be added.
> Effort needed
> - add parsing and validation of fo: elements
> - determine fo elements under influence of one or more change bars
> - when creating areas from such affected fo elements, create additional areas
> representing the change bars as defined in the FO standard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[prev in list] [next in list] [prev in thread] [next in thread]