[prev in list] [next in list] [prev in thread] [next in thread]
List: fop-dev
Subject: Re: Removing Checkstyle HTML Output [was: svn commit: r1551634 - /xmlgraphics/fop/trunk/build.xml]
From: Glenn Adams <glenn () skynav ! com>
Date: 2013-12-21 20:21:35
Message-ID: CACQ=j+dytyPqcGBSuj+BhHgkkHyZ96ikJ8ZKtorLDz9C-CXzcA () mail ! gmail ! com
[Download RAW message or body]
Actually, perhaps you could just add a second target that creates the HTML
output, or define a boolean ANT property that I could set in my local
properties that I could set to generate.
On Fri, Dec 20, 2013 at 1:21 PM, Glenn Adams <glenn@skynav.com> wrote:
> I always use the HTML version, so please re-enable.
>
>
> On Tue, Dec 17, 2013 at 10:20 AM, Vincent Hennebert <vhennebert@gmail.com>wrote:
>
>> Hi,
>>
>> I have personally never used the HTML output of Checkstyle as I find it
>> of very little use. It lists each and every file it checked along with
>> the number of errors in that file. That makes it virtually impossible to
>> find those files that have a non-zero number of errors, as they are lost
>> in an ‘ocean' of non-erroneous files.
>>
>> As I wanted to have Gump run Checkstyle, I needed to simplify the task
>> and the easiest was to remove the reference to the XSLT stylesheet that
>> creates the HTML out of the XML output.
>>
>> If anybody feels that they would miss that feature, please let me know
>> and I'll try and re-enable it in a separate target.
>>
>> Thanks,
>> Vincent
>>
>>
>> On 17/12/13 18:11, vhennebert wrote:
>>
>>> Author: vhennebert
>>> Date: Tue Dec 17 17:11:56 2013
>>> New Revision: 1551634
>>>
>>> URL: http://svn.apache.org/r1551634
>>> Log:
>>> Have Gump run Checkstyle on the source code
>>> Removed HTML output for easier integration with Gump
>>>
>>> Modified:
>>> xmlgraphics/fop/trunk/build.xml
>>>
>>> Modified: xmlgraphics/fop/trunk/build.xml
>>> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/build.
>>> xml?rev=1551634&r1=1551633&r2=1551634&view=diff
>>> ============================================================
>>> ==================
>>> --- xmlgraphics/fop/trunk/build.xml (original)
>>> +++ xmlgraphics/fop/trunk/build.xml Tue Dec 17 17:11:56 2013
>>> @@ -1042,10 +1042,8 @@ NOTE:
>>> <!-- Checkstyle
>>> -->
>>> <!-- ===================================================================
>>> -->
>>> <property name="checkstyle.location" value="${lib-tools}/checkstyle-5.5-all.jar"
>>> />
>>> - <property name="checkstyle.noframes.xslt"
>>> value="${basedir}/checkstyle-noframes.xsl" />
>>> <property name="checkstyle.config" value="${basedir}/checkstyle-5.5.xml"
>>> />
>>> <path id="checkstyle-classpath">
>>> - <path refid="libs-build-classpath"/>
>>> <pathelement location="${checkstyle.location}"/>
>>> </path>
>>> <condition property="checkstyle.avail">
>>> @@ -1053,14 +1051,12 @@ NOTE:
>>> <available classname="com.puppycrawl.tools.checkstyle.
>>> CheckStyleTask">
>>> <classpath refid="checkstyle-classpath"/>
>>> </available>
>>> - <available file="${checkstyle.noframes.xslt}"/>
>>> <available file="${checkstyle.config}"/>
>>> </and>
>>> </condition>
>>> <target name="checkstyle-avail" unless="checkstyle.avail">
>>> <echo message="Checkstyle support NOT present. Please download it
>>> from http://checkstyle.sf.net/ and"/>
>>> <echo message="... please provide ${checkstyle.location}"/>
>>> - <echo message="... please provide ${checkstyle.noframes.xslt}"/>
>>> <echo message="... please provide ${checkstyle.config}"/>
>>> </target>
>>> <target name="checkstyle" depends="package, checkstyle-avail"
>>> if="checkstyle.avail" description="Runs Checkstyle for a code quality
>>> report">
>>> @@ -1077,7 +1073,6 @@ NOTE:
>>> <fileset dir="${test.dir}" includes="**/*.java"/>
>>> <formatter type="xml" toFile="${build.dir}/report_
>>> checkstyle.xml"/>
>>> </checkstyle>
>>> - <xslt in="${build.dir}/report_checkstyle.xml"
>>> out="${build.dir}/report_checkstyle.html" style="${checkstyle.noframes.
>>> xslt}"/>
>>> </target>
>>> <!-- ===================================================================
>>> -->
>>> <!-- PMD
>>> -->
>>> @@ -1508,7 +1503,7 @@ NOTE:
>>> <!-- Special target for Gump
>>> -->
>>> <!-- ===================================================================
>>> -->
>>> <target name="gump" depends="package,transcoder-pkg"/>
>>> - <target name="gump-test" depends="junit-all">
>>> + <target name="gump-test" depends="junit-all,checkstyle">
>>> <fail>
>>> <condition>
>>> <or>
>>>
>>
>
[Attachment #3 (text/html)]
<div dir="ltr">Actually, perhaps you could just add a second target that creates the \
HTML output, or define a boolean ANT property that I could set in my local properties \
that I could set to generate.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Dec 20, 2013 at 1:21 PM, Glenn Adams <span \
dir="ltr"><<a href="mailto:glenn@skynav.com" \
target="_blank">glenn@skynav.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div dir="ltr">I always use the HTML version, so please re-enable.</div><div \
class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div \
class="gmail_quote">On Tue, Dec 17, 2013 at 10:20 AM, Vincent Hennebert <span \
dir="ltr"><<a href="mailto:vhennebert@gmail.com" \
target="_blank">vhennebert@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi,<br> <br>
I have personally never used the HTML output of Checkstyle as I find it<br>
of very little use. It lists each and every file it checked along with<br>
the number of errors in that file. That makes it virtually impossible to<br>
find those files that have a non-zero number of errors, as they are lost<br>
in an ‘ocean' of non-erroneous files.<br>
<br>
As I wanted to have Gump run Checkstyle, I needed to simplify the task<br>
and the easiest was to remove the reference to the XSLT stylesheet that<br>
creates the HTML out of the XML output.<br>
<br>
If anybody feels that they would miss that feature, please let me know<br>
and I'll try and re-enable it in a separate target.<br>
<br>
Thanks,<br>
Vincent<br>
<br>
<br>
On 17/12/13 18:11, vhennebert wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
Author: vhennebert<br>
Date: Tue Dec 17 17:11:56 2013<br>
New Revision: 1551634<br>
<br>
URL: <a href="http://svn.apache.org/r1551634" \
target="_blank">http://svn.apache.org/r1551634</a><br> Log:<br>
Have Gump run Checkstyle on the source code<br>
Removed HTML output for easier integration with Gump<br>
<br>
Modified:<br>
xmlgraphics/fop/trunk/build.<u></u>xml<br>
<br>
Modified: xmlgraphics/fop/trunk/build.<u></u>xml<br>
URL: <a href="http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/build.xml?rev=1551634&r1=1551633&r2=1551634&view=diff" \
target="_blank">http://svn.apache.org/viewvc/<u></u>xmlgraphics/fop/trunk/build.<u></u>xml?rev=1551634&r1=1551633&r2=<u></u>1551634&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- xmlgraphics/fop/trunk/build.<u></u>xml (original)<br>
+++ xmlgraphics/fop/trunk/build.<u></u>xml Tue Dec 17 17:11:56 2013<br>
@@ -1042,10 +1042,8 @@ NOTE:<br>
<!-- Checkstyle \
--><br> <!-- ==============================<u></u>==============================<u></u>======= \
--><br>
<property name="checkstyle.location" \
value="${lib-tools}/<u></u>checkstyle-5.5-all.jar" \
/><br>
- <property name="checkstyle.noframes.<u></u>xslt" \
value="${basedir}/checkstyle-<u></u>noframes.xsl" /><br>
<property name="checkstyle.config" \
value="${basedir}/checkstyle-<u></u>5.5.xml" /><br> <path \
id="checkstyle-classpath"><br>
- <path refid="libs-build-classpath"/><br>
<pathelement location="${checkstyle.<u></u>location}"/><br>
</path><br>
<condition property="checkstyle.avail"><br>
@@ -1053,14 +1051,12 @@ NOTE:<br>
<available \
classname="com.puppycrawl.<u></u>tools.checkstyle.<u></u>CheckStyleTask"><br>
<classpath refid="checkstyle-classpath"/><br>
</available><br>
- <available file="${checkstyle.noframes.<u></u>xslt}"/><br>
<available file="${checkstyle.config}"/><br>
</and><br>
</condition><br>
<target name="checkstyle-avail" \
unless="checkstyle.avail"><br> <echo message="Checkstyle \
support NOT present. Please download it from <a href="http://checkstyle.sf.net/" \
target="_blank">http://checkstyle.sf.net/</a> and"/><br>
<echo message="... please provide \
${checkstyle.location}"/><br>
- <echo message="... please provide \
${checkstyle.noframes.xslt}"/><br>
<echo message="... please provide \
${checkstyle.config}"/><br> </target><br>
<target name="checkstyle" depends="package, \
checkstyle-avail" if="checkstyle.avail" description="Runs \
Checkstyle for a code quality report"><br> @@ -1077,7 +1073,6 @@ NOTE:<br>
<fileset dir="${test.dir}" \
includes="**/*.java"/><br>
<formatter type="xml" \
toFile="${build.dir}/report_<u></u>checkstyle.xml"/><br> \
</checkstyle><br>
- <xslt in="${build.dir}/report_<u></u>checkstyle.xml" \
out="${build.dir}/report_<u></u>checkstyle.html" \
style="${checkstyle.noframes.<u></u>xslt}"/><br> </target><br>
<!-- ==============================<u></u>==============================<u></u>======= \
--><br> <!-- PMD \
--><br> @@ -1508,7 +1503,7 @@ NOTE:<br>
<!-- Special target for Gump \
--><br> <!-- ==============================<u></u>==============================<u></u>======= \
--><br>
<target name="gump" \
depends="package,transcoder-<u></u>pkg"/><br>
- <target name="gump-test" depends="junit-all"><br>
+ <target name="gump-test" \
depends="junit-all,checkstyle"<u></u>><br> <fail><br>
<condition><br>
<or><br>
</blockquote>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic