[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fop-dev
Subject:    DO NOT REPLY [Bug 25803] New:  -
From:       bugzilla () apache ! org
Date:       2003-12-29 19:02:19
[Download RAW message or body]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25803>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25803

[PATCH] PropertyList: Fixes to convertAttributeToProperty and findBaseProperty

           Summary: [PATCH] PropertyList: Fixes to
                    convertAttributeToProperty and findBaseProperty
           Product: Fop
           Version: 1.0dev
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: page-master/layout
        AssignedTo: fop-dev@xml.apache.org
        ReportedBy: spepping@leverkruid.nl


1. convertAttributeToProperty: If a base attribute is specified after
   a compound attribute, the compound value is overwritten. This patch
   fixes that: If the base attribute is handled and the base property
   already exists, the method does nothing. I do not use the method
   getExplicitBaseProp here, because its comment suggests that it
   should do more than just retrieve the value.

2. findBaseProperty: basePropertyValue is erroneously used instead of
   basePropertyName in finding the propertyID. I also think that the
   test propertyId != -1 can be replaced with the test propertyMaker
   != null. Then it is no longer necessary to find the
   propertyID. This patch makes that change.
[prev in list] [next in list] [prev in thread] [next in thread]