[prev in list] [next in list] [prev in thread] [next in thread] 

List:       flume-dev
Subject:    Re: Review Request 50378: FLUME-2960: Support Wildcards in directoryname in TaildirSource
From:       qiao wen <315524513 () qq ! com>
Date:       2017-02-28 15:38:15
Message-ID: 20170228153815.19421.42887 () reviews ! apache ! org
[Download RAW message or body]

--===============7334074573408667773==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit



> On 七月 29, 2016, 2:49 p.m., Attila Simon wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java, \
> > lines 240-242 <https://reviews.apache.org/r/50378/diff/4/?file=1457767#file1457767line240>
> >  
> > performance downgrade due to the idempotent instantiations of matchers
> 
> qiao wen wrote:
> I agree with you. But is there any good idea?
> 
> eskrm wrote:
> Extract the matchers out to the enclosing class and finalize?
> 
> Denes Arvay wrote:
> I second this, extracting the matchers will save unnecessary instance creation and \
> pattern parsing. It's possible to move both of the matchers to the `TailDirMatcher` \
> class.

OK, thanks very much. I will fix that.


- qiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50378/#review144092
-----------------------------------------------------------


On 七月 30, 2016, 5:33 a.m., qiao wen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50378/
> -----------------------------------------------------------
> 
> (Updated 七月 30, 2016, 5:33 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> In our log management project, we wan't to track many log files like this:
> /app/dir1/log.*
> /app/dir2/log.*
> ...
> /app/dirn/log.*
> But TaildirSource can't support wildcards in filegroup directory name. The \
> following config is expected: a1.sources.r1.filegroups.fg = /app/*/log.*
> 
> 
> Diffs
> -----
> 
> flume-ng-doc/sphinx/FlumeUserGuide.rst 3f08d8b 
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java \
> ad9f720  flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java \
> c341054  flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java \
> 097ee0b  
> Diff: https://reviews.apache.org/r/50378/diff/
> 
> 
> Testing
> -------
> 
> All tests in TestTaildirSource passed.
> 
> 
> Thanks,
> 
> qiao wen
> 
> 


--===============7334074573408667773==--


[prev in list] [next in list] [prev in thread] [next in thread]