[prev in list] [next in list] [prev in thread] [next in thread] 

List:       flume-dev
Subject:    Re: Review Request 52279: FLUME-2917 Provide netcat UDP source as alternative to TCP
From:       Tristan Stevens <tristan () cloudera ! com>
Date:       2017-02-22 23:10:56
Message-ID: 20170222231056.1739.7954 () reviews ! apache ! org
[Download RAW message or body]

--===============4935964663564904882==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52279/
-----------------------------------------------------------

(Updated Feb. 22, 2017, 11:10 p.m.)


Review request for Flume and Balázs Donát Bessenyei.


Changes
-------

Updated following bessbd's comments and rebased against trunk.


Repository: flume-git


Description
-------

Implementation is heavily based on the existing SyslogUDPSource - the tests and \
implementation mirror that. We could consider making it a superclass of \
SyslogUDPSource and removing the syslog parsing, if this was felt tidier.


Diffs (updated)
-----

  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java \
6bd1489   flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java \
4f4073a   flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java \
PRE-CREATION   flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java \
baa8500   flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java \
PRE-CREATION   flume-ng-doc/sphinx/FlumeUserGuide.rst d863068 

Diff: https://reviews.apache.org/r/52279/diff/


Testing
-------

Unit tests provided.


Thanks,

Tristan Stevens


--===============4935964663564904882==--


[prev in list] [next in list] [prev in thread] [next in thread]