[prev in list] [next in list] [prev in thread] [next in thread] 

List:       flume-dev
Subject:    Re: Review Request 41529: FLUME-2858, Add better exception message for malformed zookeeper,
From:       "Sam Glover" <samglover () cloudera ! com>
Date:       2015-12-28 20:29:20
Message-ID: 20151228202920.4182.57327 () reviews ! apache ! org
[Download RAW message or body]

--===============3148376074487284653==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------

(Updated Dec. 28, 2015, 8:29 p.m.)


Review request for Flume and Ted Malaska.


Changes
-------

patch 8 uploaded


Repository: flume-git


Description
-------

FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added \
default port 2181 if the zookeeperQuorum port is not given.


Diffs
-----

  flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java \
e659ada   flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java \
5560624 

Diff: https://reviews.apache.org/r/41529/diff/


Testing
-------

Yes. Ran mvn clean install with no issues, no failures.


File Attachments (updated)
----------------

patch 5
  https://reviews.apache.org/media/uploaded/files/2015/12/28/1bc03ad3-6a7b-428b-993f-3a5558fc90fa__FLUME-2858-5.patch
 patch 6
  https://reviews.apache.org/media/uploaded/files/2015/12/28/fb74e4d9-f33c-49d0-be90-1781d6cc012c__FLUME-2858-6.patch
 Update 7
  https://reviews.apache.org/media/uploaded/files/2015/12/28/fb6f5245-ec9b-4bcc-8552-0ff845aabd31__FLUME-2858-7.patch
 patch 8
  https://reviews.apache.org/media/uploaded/files/2015/12/28/d8be578d-93b6-4e94-ba3e-aba8a473b4c5__FLUME-2858-8.patch



Thanks,

Sam Glover


--===============3148376074487284653==--


[prev in list] [next in list] [prev in thread] [next in thread]