[prev in list] [next in list] [prev in thread] [next in thread] 

List:       flashrom
Subject:    Re: [flashrom] [PATCH 1/2] dediprog: Reimplement target chip option
From:       David Hendricks <david.hendricks () gmail ! com>
Date:       2016-05-07 21:32:54
Message-ID: CAJ_ov5544sMAamu8PBG4JQ9bWOxrPi3kmNoEbkKxn0UFruT3iA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Looks good to me.

Acked-by: David Hendricks <david.hendricks@gmail.com>

On Wed, May 4, 2016 at 4:37 AM, Nico Huber <nico.huber@secunet.com> wrote:

> Signed-off-by: Nico Huber <nico.huber@secunet.com>
> ---
>  dediprog.c | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/dediprog.c b/dediprog.c
> index 019de46..b7276e5 100644
> --- a/dediprog.c
> +++ b/dediprog.c
> @@ -942,7 +942,7 @@ int dediprog_init(void)
>         int spispeed_idx = 1;
>         int millivolt = 3500;
>         long usedevice = 0;
> -       long target = 1;
> +       long target = FLASH_TYPE_APPLICATION_FLASH_1;
>         int i, ret;
>
>         spispeed = extract_programmer_param("spispeed");
> @@ -1014,7 +1014,18 @@ int dediprog_init(void)
>                         free(target_str);
>                         return 1;
>                 }
> -               msg_pinfo("Using target %li.\n", target);
> +               switch (target) {
> +               case 1:
> +                       msg_pinfo("Using target %s.\n",
> "FLASH_TYPE_APPLICATION_FLASH_1");
> +                       target = FLASH_TYPE_APPLICATION_FLASH_1;
> +                       break;
> +               case 2:
> +                       msg_pinfo("Using target %s.\n",
> "FLASH_TYPE_APPLICATION_FLASH_2");
> +                       target = FLASH_TYPE_APPLICATION_FLASH_2;
> +                       break;
> +               default:
> +                       break;
> +               }
>         }
>         free(target_str);
>
> @@ -1073,7 +1084,7 @@ int dediprog_init(void)
>         dediprog_set_leds(LED_ALL);
>
>         /* Select target/socket, frequency and VCC. */
> -       if (set_target_flash(FLASH_TYPE_APPLICATION_FLASH_1) ||
> +       if (set_target_flash(target) ||
>             dediprog_set_spi_speed(spispeed_idx) ||
>             dediprog_set_spi_voltage(millivolt)) {
>                 dediprog_set_leds(LED_ERROR);
> --
> 2.7.0
>
>
> _______________________________________________
> flashrom mailing list
> flashrom@flashrom.org
> https://www.flashrom.org/mailman/listinfo/flashrom
>

[Attachment #5 (text/html)]

<div dir="ltr">Looks good to me.<div><br></div><div>Acked-by: David Hendricks &lt;<a \
href="mailto:david.hendricks@gmail.com">david.hendricks@gmail.com</a>&gt;</div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Wed, May 4, 2016 at 4:37 AM, Nico \
Huber <span dir="ltr">&lt;<a href="mailto:nico.huber@secunet.com" \
target="_blank">nico.huber@secunet.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Signed-off-by: Nico Huber &lt;<a \
                href="mailto:nico.huber@secunet.com">nico.huber@secunet.com</a>&gt;<br>
                
---<br>
  dediprog.c | 17 ++++++++++++++---<br>
  1 file changed, 14 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/dediprog.c b/dediprog.c<br>
index 019de46..b7276e5 100644<br>
--- a/dediprog.c<br>
+++ b/dediprog.c<br>
@@ -942,7 +942,7 @@ int dediprog_init(void)<br>
            int spispeed_idx = 1;<br>
            int millivolt = 3500;<br>
            long usedevice = 0;<br>
-           long target = 1;<br>
+           long target = FLASH_TYPE_APPLICATION_FLASH_1;<br>
            int i, ret;<br>
<br>
            spispeed = extract_programmer_param(&quot;spispeed&quot;);<br>
@@ -1014,7 +1014,18 @@ int dediprog_init(void)<br>
                                    free(target_str);<br>
                                    return 1;<br>
                        }<br>
-                       msg_pinfo(&quot;Using target %li.\n&quot;, target);<br>
+                       switch (target) {<br>
+                       case 1:<br>
+                                   msg_pinfo(&quot;Using target %s.\n&quot;, \
&quot;FLASH_TYPE_APPLICATION_FLASH_1&quot;);<br> +                                   \
target = FLASH_TYPE_APPLICATION_FLASH_1;<br> +                                   \
break;<br> +                       case 2:<br>
+                                   msg_pinfo(&quot;Using target %s.\n&quot;, \
&quot;FLASH_TYPE_APPLICATION_FLASH_2&quot;);<br> +                                   \
target = FLASH_TYPE_APPLICATION_FLASH_2;<br> +                                   \
break;<br> +                       default:<br>
+                                   break;<br>
+                       }<br>
            }<br>
            free(target_str);<br>
<br>
@@ -1073,7 +1084,7 @@ int dediprog_init(void)<br>
            dediprog_set_leds(LED_ALL);<br>
<br>
            /* Select target/socket, frequency and VCC. */<br>
-           if (set_target_flash(FLASH_TYPE_APPLICATION_FLASH_1) ||<br>
+           if (set_target_flash(target) ||<br>
                  dediprog_set_spi_speed(spispeed_idx) ||<br>
                  dediprog_set_spi_voltage(millivolt)) {<br>
                        dediprog_set_leds(LED_ERROR);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.0<br>
<br>
<br>
_______________________________________________<br>
flashrom mailing list<br>
<a href="mailto:flashrom@flashrom.org">flashrom@flashrom.org</a><br>
<a href="https://www.flashrom.org/mailman/listinfo/flashrom" rel="noreferrer" \
target="_blank">https://www.flashrom.org/mailman/listinfo/flashrom</a><br> \
</font></span></blockquote></div><br></div>



_______________________________________________
flashrom mailing list
flashrom@flashrom.org
https://www.flashrom.org/mailman/listinfo/flashrom

[prev in list] [next in list] [prev in thread] [next in thread]