[prev in list] [next in list] [prev in thread] [next in thread] 

List:       flashrom
Subject:    Re: [flashrom] [PATCH] Bitbanging SPI driver
From:       Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 () gmx ! net>
Date:       2009-09-28 13:16:04
Message-ID: 4AC0B714.7010001 () gmx ! net
[Download RAW message or body]

On 28.09.2009 12:33, Uwe Hermann wrote:
> On Thu, Sep 24, 2009 at 01:11:46AM +0200, Carl-Daniel Hailfinger wrote:
>   
>> This is the bitbanging SPI driver infrastructure.
>>
>> If you want support for a particular piece of hardware, just fill in
>> a few functions in spi_bitbang_master_table. That's it.
>> On top of this, the RayeR SPI flasher should be supportable in ~20 LOC.
>>
>> Tested, trace looks OK.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>>     
>
> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
>
> But please see below.
>   

Thanks a lot for the review. I changed the naming a few times in my
early iterations of the patch and it seems I converted only half of the
names.

Committed in r736, will send a followup patch to address your comments.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/


_______________________________________________
flashrom mailing list
flashrom@flashrom.org
http://www.flashrom.org/mailman/listinfo/flashrom

[prev in list] [next in list] [prev in thread] [next in thread]