[prev in list] [next in list] [prev in thread] [next in thread] 

List:       flac-dev
Subject:    [flac-dev] PATCH: fix comments
From:       lvqcl <lvqcl.mail () gmail ! com>
Date:       2014-03-09 21:11:28
Message-ID: op.xcg3teg9cba0by () userhome-pc
[Download RAW message or body]

1) FLAC__seekable_stream_decoder_reset() was renamed to FLAC__stream_decoder_reset()
many years ago

2) I tried to update comments in precompute_partition_info_sums_().
["fix_comment1.patch" (fix_comment1.patch)]

diff --git a/src/libFLAC/stream_decoder.c b/src/libFLAC/stream_decoder.c
index cd41b5e..ddce8d6 100644
--- a/src/libFLAC/stream_decoder.c
+++ b/src/libFLAC/stream_decoder.c
@@ -664,7 +664,7 @@ FLAC_API FLAC__bool FLAC__stream_decoder_finish(FLAC__StreamDecoder *decoder)
 	if(decoder->protected_->state == FLAC__STREAM_DECODER_UNINITIALIZED)
 		return true;
 
-	/* see the comment in FLAC__seekable_stream_decoder_reset() as to why we
+	/* see the comment in FLAC__stream_decoder_reset() as to why we
 	 * always call FLAC__MD5Final()
 	 */
 	FLAC__MD5Final(decoder->private_->computed_md5sum, &decoder->private_->md5context);

["fix_comment2.patch" (fix_comment2.patch)]

diff --git a/src/libFLAC/stream_encoder.c b/src/libFLAC/stream_encoder.c
index 86ce7f2..289846c 100644
--- a/src/libFLAC/stream_encoder.c
+++ b/src/libFLAC/stream_encoder.c
@@ -3842,8 +3842,9 @@ void precompute_partition_info_sums_(
 	FLAC__ASSERT(default_partition_samples > predictor_order);
 
 #if defined(FLAC__CPU_IA32) && !defined FLAC__NO_ASM && defined FLAC__HAS_NASM && 0
-	/* slightly pessimistic but still catches all common cases */
 	/* WATCHOUT: "+ bps" is an assumption that the average residual magnitude will not \
be more than "bps" bits */ +	/* previously the condition was: \
if(FLAC__bitmath_ilog2(default_partition_samples) + bps < 32) */ +	/* see \
http://git.xiph.org/?p=flac.git;a=commit;h=6f7ec60c7e7f05f5ab0b1cf6b7b0945e44afcd4b \
*/  if(bps <= 16) {
 		FLAC__precompute_partition_info_sums_32bit_asm_ia32_(residual, \
abs_residual_partition_sums, residual_samples + predictor_order, predictor_order, \
min_partition_order, max_partition_order);  return;
@@ -3853,8 +3854,9 @@ void precompute_partition_info_sums_(
 	/* first do max_partition_order */
 	{
 		unsigned partition, residual_sample, end = (unsigned)(-(int)predictor_order);
-		/* slightly pessimistic but still catches all common cases */
 		/* WATCHOUT: "+ bps" is an assumption that the average residual magnitude will not \
be more than "bps" bits */ +		/* previously the condition was: \
if(FLAC__bitmath_ilog2(default_partition_samples) + bps < 32) */ +		/* see \
http://git.xiph.org/?p=flac.git;a=commit;h=6f7ec60c7e7f05f5ab0b1cf6b7b0945e44afcd4b \
*/  if(bps <= 16) {
 			FLAC__uint32 abs_residual_partition_sum;
 



_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[prev in list] [next in list] [prev in thread] [next in thread]