[prev in list] [next in list] [prev in thread] [next in thread]
List: flac-dev
Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain
From: Earl Chew <earl_chew () yahoo ! com>
Date: 2012-03-18 23:53:27
Message-ID: 1332114807.87663.YahooMailNeo () web162402 ! mail ! bf1 ! yahoo ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Erik,
Thanks for the update. It certainly was a strange problem to debug.
Earl
________________________________
From: Erik de Castro Lopo <mle+la@mega-nerd.com>
To: flac-dev@xiph.org
Cc: Earl Chew <earl_chew@yahoo.com>
Sent: Sunday, March 18, 2012 1:36:42 PM
Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain
Earl Chew wrote:
> I cannot reproduce the problem you see with either dash(1) or bash(1).
Just found something really werid. I opened the patch in a text editor
that doesn't support unicode and found this:
+ awk -- '
+ BEGIN {
+ samplerate = '$1';
Everywhere there was supposed to be a space (hex 0a) there was a pair
(hex c2 0a). In my regular unicode aware editor, the hex c2 0a pair
just showed up as a space. I just checked and your original patch also
has these extra bytes. This may be something added by YahooMail.
With the cruft removed, the patch applied and the tests ran correctly.
I'll commit and push after a little testing.
Thanks.
Cheers,
Erik
--
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
[Attachment #5 (text/html)]
<html><body><div style="color:#000; background-color:#fff; font-family:times new \
roman, new york, times, \
serif;font-size:12pt"><div><span>Erik,</span></div><div><br></div><div>Thanks for the \
update. It certainly was a strange problem to \
debug.<br></div><div><br><span></span></div><div><span>Earl</span></div><div><br></div> \
<div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> \
<div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> \
<div dir="ltr"> <font size="2" face="Arial"> <hr size="1"> <b><span \
style="font-weight:bold;">From:</span></b> Erik de Castro Lopo \
<mle+la@mega-nerd.com><br> <b><span style="font-weight: bold;">To:</span></b> \
flac-dev@xiph.org <br><b><span style="font-weight: bold;">Cc:</span></b> Earl Chew \
<earl_chew@yahoo.com> <br> <b><span style="font-weight: bold;">Sent:</span></b> \
Sunday, March 18, 2012 1:36:42 PM<br> <b><span style="font-weight: \
bold;">Subject:</span></b> Re: [flac-dev] PATCH: Add test for metaflac \
--add-replay-gain<br> </font> </div> <br>Earl Chew wrote:<br><br>> I cannot \
reproduce the problem you see with either dash(1) or bash(1).<br><br>Just found \
something really werid. I opened the patch in a text editor<br>that doesn't support \
unicode and found this:<br><br> + awk -- \
'<br> + BEGIN {<br> + \
samplerate = \
'$1';<br><br>Everywhere there was supposed to be a space (hex 0a) there was a \
pair<br>(hex c2 0a). In my regular unicode aware editor, the hex c2 0a pair<br>just \
showed up as a space. I just checked and your original patch also<br>has these extra \
bytes. This may be something added by YahooMail.<br><br>With the cruft removed, the \
patch applied and the tests ran correctly.<br><br>I'll commit and push after a \
little testing.<br><br>Thanks.<br><br>Cheers,<br>Erik<br>-- \
<br>----------------------------------------------------------------------<br>Erik de \
Castro Lopo<br><a href="http://www.mega-nerd.com/" \
target="_blank">http://www.mega-nerd.com/</a><br><br><br> </div> </div> \
</div></body></html>
_______________________________________________
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic