'[Flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       flac-dev
Subject:    [Flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
From:       Earl Chew <earl_chew () yahoo ! com>
Date:       2012-01-06 17:00:17
Message-ID: 1325869217.50138.YahooMailNeo () web36504 ! mail ! mud ! yahoo ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed \
if the sample frequency is not a multiple of 75 because the index would only be \
approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, \
so allow it as a special case. This allows metaflac_test.sh to pass.


[Attachment #5 (text/html)]

<html><body><div style="color:#000; background-color:#fff; font-family:times new \
roman, new york, times, serif;font-size:12pt"><div>When reading the INDEX from the \
cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a \
multiple of 75 because the index would only be approximate. However, 00:00:00 is \
_exact_ because it denotes the start of the track, so allow it as a special case. \
                This allows metaflac_test.sh to \
                pass.<br><br></div></div></body></html>
---2114655128-51558577-1325869217=:50138--


["flac.diff" (application/octet-stream)]

diff --git a/src/share/grabbag/cuesheet.c b/src/share/grabbag/cuesheet.c
index 682ee3d..1f98c15 100644
--- a/src/share/grabbag/cuesheet.c
+++ b/src/share/grabbag/cuesheet.c
@@ -366,7 +366,8 @@ static FLAC__bool local__cuesheet_parse_(FILE *file, const char \
**error_message,  }
 					}
 				}
-				else if(sample_rate % 75) {
+				else if(sample_rate % 75 && xx) {
+                                        /* only sample zero is exact */
 					*error_message = "illegal INDEX offset (MM:SS:FF form not allowed if sample \
rate is not a multiple of 75)";  return false;
 				}



_______________________________________________
Flac-dev mailing list
Flac-dev@xiph.org
http://lists.xiph.org/mailman/listinfo/flac-dev


[prev in list] [next in list] [prev in thread] [next in thread] 
