[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-test-list
Subject:    SV: sky2 driver
From:       "Christian Magnusson" <mag () mag ! cx>
Date:       2006-02-13 22:01:54
Message-ID: 001a01c630e9$1a24f260$2003a8c0 () MAGACER
[Download RAW message or body]

Thanks...

I have applied the patch now, and I'll tell you if it works for me.
Will this patch be added to next kernel-release?

/Christian


-----Ursprungligt meddelande-----
Från: shemminger [mailto:shemminger@osdl.org] 
Skickat: den 13 februari 2006 20:35
Till: Christian Magnusson
Kopia: For testers of Fedora Core development releases
Ämne: Re: sky2 driver

You need this patch, there is a race in the status handling.

Fix a hang on Yukon-EC (0xb6) rev 1 where suddenly no more interrupts were
delivered.

I don't know the real cause of the hang due to lack of docs, but the patch
has been running stable for a few hours whereas the unmodified driver will
hang after less than 2 minutes.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

--- sky2.orig/drivers/net/sky2.c	2006-02-13 10:26:08.000000000 -0800
+++ sky2/drivers/net/sky2.c	2006-02-13 10:31:50.000000000 -0800
@@ -1923,6 +1923,14 @@
 			sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_START);
 		}
 
+		/* Kick status timer, it seems that status timer is not
+		 * reset on clear??
+		 */
+		if (sky2_read8(hw, STAT_LEV_TIMER_CTRL) == TIM_START) {
+			sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_STOP);
+			sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_START);
+		}
+
 		netif_rx_complete(dev0);
 		hw->intr_mask |= Y2_IS_STAT_BMU;
 		sky2_write32(hw, B0_IMSK, hw->intr_mask);



-- 
fedora-test-list mailing list
fedora-test-list@redhat.com
To unsubscribe: 
https://www.redhat.com/mailman/listinfo/fedora-test-list
[prev in list] [next in list] [prev in thread] [next in thread]