[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-directory-devel
Subject:    =?utf-8?q?=5B389-devel=5D?= REVIEW: Re: Re: query: ldapu_ function struct
From:       William Brown <wibrown () redhat ! com>
Date:       2017-05-05 5:28:57
Message-ID: 1493962137.15180.39.camel () redhat ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Fri, 2017-05-05 at 15:20 +1000, William Brown wrote:
> On Fri, 2017-05-05 at 15:10 +1000, William Brown wrote:
> > Hi all,
> > 
> > I've been looking at https://pagure.io/389-ds-base/issue/49053 and
> > noticed issues with the functions here. It seems we export a set of
> > macros (like ldapu_err2string) that overload on a symbol name. Given the
> > current usage of these, I think we can purge the macros, and the
> > function table and just rely on our default implementations of these.
> > 
> > The impact is that we would no longer support compilation on Windows.
> > Given that I don't think we have built on windows in maybe years, (our
> > remaining supported platforms are Linux and FreeBSD today), I would like
> > to purge this code and simplify this so that I can enable LTO. 
> > 
> > If I don't hear anything in the next few days, I'll go ahead and do this
> > anyway, 
> > 
> 
> Reading the code, I think we don't use the macros anyway, we use the
> symbols, so I'm going to write up a patch for this and we can discuss. 
> 

https://pagure.io/389-ds-base/issue/49053

https://pagure.io/389-ds-base/issue/raw/files/27333b0da22ce318465b27809021ff0612aefae70c2467ac94abb7f143c417c0-0001-Ticket-49053-Enable-flto-for-DS.patch


-- 
Sincerely,

William Brown
Software Engineer
Red Hat, Australia/Brisbane


["signature.asc" (application/pgp-signature)]
[Attachment #6 (text/plain)]

_______________________________________________
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org


[prev in list] [next in list] [prev in thread] [next in thread]