[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-directory-devel
Subject:    Re: [389-devel] Please review: [nunc-stans] Remove extra curly brace
From:       Lukas Slebodnik <lslebodn () redhat ! com>
Date:       2015-11-11 6:30:20
Message-ID: 20151111063020.GA3014 () mail ! corp ! redhat ! com
[Download RAW message or body]

On (10/11/15 21:29), Lukas Slebodnik wrote:
>On (10/11/15 10:25), Noriko Hosoi wrote:
>>On 11/10/2015 01:29 AM, Lukas Slebodnik wrote:
>>>ehlo,
>>>
>>>I'm too lazy to follow all contribution steps for one liner :-)
>>>So simple patch is attached.
>>>
>>>LS
>>>
>>>
>>>--
>>>389-devel mailing list
>>>389-devel@lists.fedoraproject.org
>>>https://admin.fedoraproject.org/mailman/listinfo/389-devel
>>Thank you for fixing the syntax error, Lukas.
>>
>>I hope you don't mind to modify the comment as follows.
>>
>>commit cc1c55cf542fc6114e308390d91c5b094b3aa07a
>>Author: Lukas Slebodnik <lslebodn@redhat.com>
>>Date:   Tue Nov 10 10:06:55 2015 -0800
>>
>>    Ticket #48257 - Fix coverity issues - 08/24/2015
>>
>>    Description: Remove extra curly brace
>>
>>    Introduced by commit 4b9a54f7ba5f78b0402c0695998cca049ea3f095.
>>
>>--noriko
>Updated patch is attached.
>
>If there are any other issues in commit message.
>Feel free to modify it.
>
>Thank you very much for review.
>
>LS
>

Attached is updated patch which also fixes indentation of return statement.

LS

["0001-Ticket-48257-Fix-coverity-issues-08-24-2015.patch" (text/plain)]

From 94f9340cab36ff9236b737159ba8212d8f58bfab Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn@redhat.com>
Date: Tue, 10 Nov 2015 10:16:46 +0100
Subject: [PATCH] Ticket #48257 - Fix coverity issues - 08/24/2015

Description: Remove extra curly brace and fix indentation of related code

Introduced by commit 4b9a54f7ba5f78b0402c0695998cca049ea3f095.

src/ringbuffer/ringbuffer_get_and_put.c:17:3: warning: control may reach end of \
non-void function [-Wreturn-type]  }
  ^
src/ringbuffer/ringbuffer_get_and_put.c:19:18: error: unknown type name 'rs'
  queue_dequeue( rs->qs, (void **) fe );
                 ^
src/ringbuffer/ringbuffer_get_and_put.c:19:20: error: expected ')'
  queue_dequeue( rs->qs, (void **) fe );
                   ^
src/ringbuffer/ringbuffer_get_and_put.c:19:16: note: to match this '('
  queue_dequeue( rs->qs, (void **) fe );
               ^
src/ringbuffer/ringbuffer_get_and_put.c:19:3: warning: type specifier missing, \
defaults to 'int' [-Wimplicit-int]  queue_dequeue( rs->qs, (void **) fe );
  ^
src/ringbuffer/ringbuffer_get_and_put.c:21:3: error: expected identifier or '('
  return( *fe );
  ^
src/ringbuffer/ringbuffer_get_and_put.c:22:1: error: extraneous closing brace ('}')
}
^
2 warnings and 4 errors generated.

Signed-off-by: Lukas Slebodnik <lslebodn@redhat.com>
---
 liblfds/src/ringbuffer/ringbuffer_get_and_put.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/liblfds/src/ringbuffer/ringbuffer_get_and_put.c \
b/liblfds/src/ringbuffer/ringbuffer_get_and_put.c index \
625ed6e23020645b352824b01f0ad9cb74cbc8be..24f7a4a2092d296cd02b6680747f5a0ca60d36e2 \
                100644
--- a/liblfds/src/ringbuffer/ringbuffer_get_and_put.c
+++ b/liblfds/src/ringbuffer/ringbuffer_get_and_put.c
@@ -12,8 +12,7 @@ struct freelist_element *ringbuffer_get_read_element( struct \
ringbuffer_state *r  assert( rs != NULL );
     assert( fe != NULL );
 #endif
-      return NULL;
-    }
+    return NULL;
   }
 
   queue_dequeue( rs->qs, (void **) fe );
-- 
2.5.0


[Attachment #4 (text/plain)]

--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[prev in list] [next in list] [prev in thread] [next in thread]