'Re: [389-devel] Please review ticket 47976: deadlock in mep delete post op'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-directory-devel
Subject:    Re: [389-devel] Please review ticket 47976: deadlock in mep delete post op
From:       thierry bordaz <tbordaz () redhat ! com>
Date:       2015-11-04 14:27:02
Message-ID: 563A15B6.1080205 () redhat ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Hi Ludwig, Rich,

you were right (as usual !), dblayer_get_pvt_txn/dblayer_push_pvt_txn 
are doing the magic.
Now the fix is a oneline fix !

https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-2-deadlock-in-mep-delete-post-op.patch

thanks
thierry
On 11/03/2015 06:01 PM, Ludwig Krispenz wrote:
> Hi Thierry,
> 
> we already had started to discuss on IRC, but here are my thoughts again.
> 
> Is it necessary to explicitely set the txn in the plugin ? The txn 
> will be found when ldbm_back_delete() does dblayer_txn_begin(9 and it 
> checks the per thread stack of txns.
> In my opinion the real problem is not to set  the txn in id2entry, 
> which will then try to read a locked page.
> 
> Ludwig
> 
> On 11/03/2015 05:40 PM, thierry bordaz wrote:
> > ticket https://fedorahosted.org/389/ticket/47976
> > 
> > fix 
> > https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-deadlock-in-mep-delete-post-op.patch
> >  
> > test case: 
> > https://fedorahosted.org/389/attachment/ticket/47976/0002-Ticket-47976-test-case.patch
> >  
> > 
> > 
> > --
> > 389-devel mailing list
> > 389-devel@lists.fedoraproject.org
> > https://admin.fedoraproject.org/mailman/listinfo/389-devel
> 
> 
> 
> --
> 389-devel mailing list
> 389-devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/389-devel

[Attachment #5 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Hi Ludwig, Rich,<br>
      <br>
      you were right (as usual !),
      dblayer_get_pvt_txn/dblayer_push_pvt_txn are doing the magic.<br>
      Now the fix is a oneline fix !<br>
      <br>
<a class="moz-txt-link-freetext" \
href="https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-2-deadloc \
k-in-mep-delete-post-op.patch">https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-2-deadlock-in-mep-delete-post-op.patch</a><br>
  <br>
      thanks<br>
      thierry<br>
      On 11/03/2015 06:01 PM, Ludwig Krispenz wrote:<br>
    </div>
    <blockquote cite="mid:5638E86F.3080301@redhat.com" type="cite">
      <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
      Hi Thierry,<br>
      <br>
      we already had started to discuss on IRC, but here are my thoughts
      again.<br>
      <br>
      Is it necessary to explicitely set the txn in the plugin ? The txn
      will be found when ldbm_back_delete() does dblayer_txn_begin(9 and
      it checks the per thread stack of txns. <br>
      In my opinion the real problem is not to set   the txn in id2entry,
      which will then try to read a locked page.<br>
      <br>
      Ludwig<br>
      <br>
      <div class="moz-cite-prefix">On 11/03/2015 05:40 PM, thierry
        bordaz wrote:<br>
      </div>
      <blockquote cite="mid:5638E38F.6020602@redhat.com" type="cite">
        <meta http-equiv="content-type" content="text/html;
          charset=UTF-8">
        <font face="Times New Roman, Times, serif">ticket <a
            moz-do-not-send="true" class="moz-txt-link-freetext"
            href="https://fedorahosted.org/389/ticket/47976">https://fedorahosted.org/389/ticket/47976</a><br>
  <br>
          fix <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-deadlock- \
in-mep-delete-post-op.patch">https://fedorahosted.org/389/attachment/ticket/47976/0001-Ticket-47976-deadlock-in-mep-delete-post-op.patch</a><br>
  <br>
          test case: <a moz-do-not-send="true"
            class="moz-txt-link-freetext"
href="https://fedorahosted.org/389/attachment/ticket/47976/0002-Ticket-47976-test-case \
.patch">https://fedorahosted.org/389/attachment/ticket/47976/0002-Ticket-47976-test-case.patch</a><br>
  <br>
        </font> <br>
        <fieldset class="mimeAttachmentHeader"></fieldset>
        <br>
        <pre wrap="">--
389-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" \
href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a> \
<a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
  </blockquote>
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">--
389-devel mailing list
<a class="moz-txt-link-abbreviated" \
href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a> \
<a class="moz-txt-link-freetext" \
href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
  </blockquote>
    <br>
  </body>
</html>

[Attachment #6 (text/plain)]

--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[prev in list] [next in list] [prev in thread] [next in thread] 