[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-directory-devel
Subject:    [389-devel] Please review: [389 Project] #307: htmladmin keeps segfaulting
From:       Noriko Hosoi <nhosoi () redhat ! com>
Date:       2012-03-16 0:26:22
Message-ID: 4F6288AE.9070004 () redhat ! com
[Download RAW message or body]

https://fedorahosted.org/389/ticket/307

https://fedorahosted.org/389/attachment/ticket/307/0001-Trac-Ticket-307-htmladmin-keeps-segfaulting.patch

Fix Description:
  PR_GetHostByName was used to get PRHostEnt in htmladmin, but it
  was called only when the first character of host was not digit.
  The direct cause of the crash was the PRHostEnt variable to fill
  in in PR_GetHostByName was not initialized, thus if the hostname
  started with digit, the uninitialized, garbage address in the
  variable was accessed, which crashed htmladmin.

  This patch removes the hostname check and replaces PR_GetHostByName
  with PR_GetAddrInfoByName to support IPv6 environment.  Also, to
  support numerical address, PR_StringToNetAddr is added before
  trying PR_GetAddrInfoByName.

  Another cgi statpingserv has the same coding style.  It is being
  fixed, too.

--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
[prev in list] [next in list] [prev in thread] [next in thread]