[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-directory-commits
Subject:    =?utf-8?q?=5B389-commits=5D?= [389-ds-base] branch 389-ds-base-1.3.9 updated: Ticket 50063 - Crash a
From:       pagure () pagure ! io
Date:       2019-03-29 19:13:39
Message-ID: 20190329191338.11128.65776 () pagure01 ! fedoraproject ! org
[Download RAW message or body]

This is an automated email from the git hooks/post-receive script.

mreynolds pushed a commit to branch 389-ds-base-1.3.9
in repository 389-ds-base.

The following commit(s) were added to refs/heads/389-ds-base-1.3.9 by this push:
     new b5e599a  Ticket 50063 - Crash after attempting to restore a single backend
b5e599a is described below

commit b5e599ae5a0bfaad77b8ba8a1846f1b56fa5993c
Author: Mark Reynolds <mreynolds@redhat.com>
AuthorDate: Fri Nov 30 11:45:39 2018 -0500

    Ticket 50063 - Crash after attempting to restore a single backend
    
    Description:  While we do not support backup/restore of individual backends,
                  it should not crash the server either.  PR_OpenDir will crash
                  if the file name is NULL, so this fix just prevents the crash
                  by returning an error if the filename is NULL.
    
    https://pagure.io/389-ds-base/issue/50063
    
    Reviewed by: firstyear & tbordaz(Thanks!!)
    
    (cherry picked from commit d36f796a7b35bade5a05e197690abf4e49d212ce)
---
 ldap/servers/slapd/back-ldbm/dblayer.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ldap/servers/slapd/back-ldbm/dblayer.c b/ldap/servers/slapd/back-ldbm/dblayer.c
index fa931cc..64a4e9e 100644
--- a/ldap/servers/slapd/back-ldbm/dblayer.c
+++ b/ldap/servers/slapd/back-ldbm/dblayer.c
@@ -5292,6 +5292,11 @@ dblayer_delete_database_ex(struct ldbminfo *li, char *instance, char *cldir)
     }
 
     /* now smash everything else in the db/ dir */
+    if (priv->dblayer_home_directory == NULL){
+        slapi_log_err(SLAPI_LOG_ERR, "dblayer_delete_database_ex",
+                      "dblayer_home_directory is NULL, can not proceed\n");
+        return -1;
+    }
     dirhandle = PR_OpenDir(priv->dblayer_home_directory);
     if (!dirhandle) {
         slapi_log_err(SLAPI_LOG_ERR, "dblayer_delete_database_ex", "PR_OpenDir (%s) failed (%d): %s\n",

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
389-commits mailing list -- 389-commits@lists.fedoraproject.org
To unsubscribe send an email to 389-commits-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-commits@lists.fedoraproject.org

[prev in list] [next in list] [prev in thread] [next in thread]