[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-directory-commits
Subject:    [389-commits] Branch '389-ds-base-1.3.3' - ldap/servers
From:       Noriko Hosoi <nhosoi () fedoraproject ! org>
Date:       2015-02-28 2:15:55
Message-ID: 20150228021555.F409860DBC () fedorahosted ! org
[Download RAW message or body]

 ldap/servers/slapd/log.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a875da1d99f05e15e0ae7f1cd57049f35209044d
Author: Noriko Hosoi <nhosoi@redhat.com>
Date:   Fri Feb 27 18:10:19 2015 -0800

    Ticket #48048 - Fix coverity issues - 2015/2/24
    
    Description: Due to the changes made on NSPRIu64 and NSPRI64 along with
    this fix:
    > Coverity defect 13075 - Explicit null dereferenced (FORWARD_NULL)
    > NSPRIu64 and NSPRI64 is defined based upon the architecture and compiler.
    casting PRInt64 to (long long int) in the log print is no longer needed.
    Got rid of them.
    
    Reviewed and advised by rmeggins@redhat.com (Thank you, Rich!!)
    
    https://fedorahosted.org/389/ticket/48048
    (cherry picked from commit 8f1eef1b53a88e5d42e3313eae5fe63b9a7dd99b)

diff --git a/ldap/servers/slapd/log.c b/ldap/servers/slapd/log.c
index 944876c..1014a03 100644
--- a/ldap/servers/slapd/log.c
+++ b/ldap/servers/slapd/log.c
@@ -2293,7 +2293,7 @@ log__open_accesslogfile(int logfile_state, int locked)
 		log_convert_time (logp->l_ctime, tbuf, 1 /*short*/);
 		PR_snprintf(buffer, sizeof(buffer), "LOGINFO:%s%s.%s (%lu) (%"
 			NSPRI64 "d)\n", PREVLOGFILE, loginfo.log_access_file, tbuf, 
-			logp->l_ctime, (long long int)logp->l_size);
+			logp->l_ctime, logp->l_size);
 		LOG_WRITE(fpinfo, buffer, strlen(buffer), 0);
 		logp = logp->l_next;
 	}
@@ -3906,7 +3906,7 @@ log__open_errorlogfile(int logfile_state, int locked)
 		log_convert_time (logp->l_ctime, tbuf, 1 /*short */);
 		PR_snprintf(buffer, sizeof(buffer), "LOGINFO:%s%s.%s (%lu) (%" 
 			NSPRI64 "d)\n", PREVLOGFILE, loginfo.log_error_file, tbuf,
-			logp->l_ctime, (long long int)logp->l_size);
+			logp->l_ctime, logp->l_size);
 		LOG_WRITE(fpinfo, buffer, strlen(buffer), 0);
 		logp = logp->l_next;
 	}
@@ -4033,7 +4033,7 @@ log__open_auditlogfile(int logfile_state, int locked)
 		log_convert_time (logp->l_ctime, tbuf, 1 /*short */);	
 		PR_snprintf(buffer, sizeof(buffer), "LOGINFO:%s%s.%s (%lu) (%"
 			NSPRI64 "d)\n", PREVLOGFILE, loginfo.log_audit_file, tbuf, 
-			logp->l_ctime, (long long int)logp->l_size);
+			logp->l_ctime, logp->l_size);
 		LOG_WRITE(fpinfo, buffer, strlen(buffer), 0);
 		logp = logp->l_next;
 	}


--
389 commits mailing list
389-commits@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-commits
[prev in list] [next in list] [prev in thread] [next in thread]