[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-directory-commits
Subject:    [389-commits] Branch '389-ds-base-1.2.10' - ldap/servers
From:       Mark Reynolds <mreynolds () fedoraproject ! org>
Date:       2013-03-22 19:05:39
Message-ID: 20130322190539.9562814AA () fedorahosted ! org
[Download RAW message or body]

 ldap/servers/slapd/plugin_acl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit caa580edbe0a77c0e4c93c8a63dfd5b6b3a88bff
Author: Mark Reynolds <mreynolds@redhat.com>
Date:   Mon Sep 24 11:26:49 2012 -0400

    Coverity issue 13091
    
    Bug Description:  Local var array "mychange" can go out of scope
    
    Fix Description:  Declare "mychange" at the top of the function so it does not go out of scope.
    
    Reviewed by: nkinder(Thanks!)
    (cherry picked from commit d58ae20b75ccae99b2122a4a0d4fcf773a51115a)

diff --git a/ldap/servers/slapd/plugin_acl.c b/ldap/servers/slapd/plugin_acl.c
index 3bc3f21..eebc292 100644
--- a/ldap/servers/slapd/plugin_acl.c
+++ b/ldap/servers/slapd/plugin_acl.c
@@ -136,6 +136,7 @@ plugin_call_acl_mods_update ( Slapi_PBlock *pb, int optype )
 	struct slapdplugin	*p;
 	int					rc = 0;
 	void				*change = NULL;
+	void				*mychange[2];
 	Slapi_Entry			*te = NULL;
 	Slapi_DN			*sdn = NULL;
 	Operation			*operation;
@@ -158,7 +159,6 @@ plugin_call_acl_mods_update ( Slapi_PBlock *pb, int optype )
 		break;
 	  case SLAPI_OPERATION_MODRDN:
 	  {
-		void *mychange[2];
 		char *newrdn = NULL;
 		Slapi_DN *psdn = NULL;
 		char *pdn = NULL;


--
389 commits mailing list
389-commits@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-commits
[prev in list] [next in list] [prev in thread] [next in thread]