[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-directory-commits
Subject:    [389-commits] ldap/servers
From:       Noriko Hosoi <nhosoi () fedoraproject ! org>
Date:       2012-09-27 18:07:36
Message-ID: 20120927180736.D1909A2966 () fedorahosted ! org
[Download RAW message or body]

 ldap/servers/slapd/dn.c |   14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

New commits:
commit 4754fb7da3066119576a115a04470b91c4184257
Author: Noriko Hosoi <nhosoi@totoro.usersys.redhat.com>
Date:   Wed Sep 26 16:55:39 2012 -0700

    Coverity defects
    
    13093: Resource leak
    Fix description: If udn is allocated in ndn_cache_lookup and it
    has no chance to be consumed in ndn_cache_add, udn is released.

diff --git a/ldap/servers/slapd/dn.c b/ldap/servers/slapd/dn.c
index b620eee..0ca44e7 100644
--- a/ldap/servers/slapd/dn.c
+++ b/ldap/servers/slapd/dn.c
@@ -534,7 +534,7 @@ slapi_dn_normalize_ext(char *src, size_t src_len, char **dest, size_t *dest_len)
     char *ends = NULL;
     char *endd = NULL;
     char *lastesc = NULL;
-    char *udn;
+    char *udn = NULL;
     /* rdn avs for the main DN */
     char *typestart = NULL;
     int rdn_av_count = 0;
@@ -1129,8 +1129,12 @@ bail:
         *d = '\0';
     }
     /* add this dn to the normalized dn cache */
-    if(dest && *dest && dest_len && *dest_len) {
-        ndn_cache_add(udn, src_len, *dest, *dest_len);
+    if (udn) {
+        if(dest && *dest && dest_len && *dest_len) {
+            ndn_cache_add(udn, src_len, *dest, *dest_len);
+        } else {
+            slapi_ch_free_string(&udn);
+        }
     }
 
     return rc;
@@ -2695,6 +2699,10 @@ ndn_cache_lookup(char *dn, size_t dn_len, char **result, char **udn, int *rc)
     char *ndn, *key;
     int rv = 0;
 
+    if(NULL == udn){
+        return rv;
+    }
+    *udn = NULL;
     if(ndn_started == 0){
         return rv;
     }


--
389 commits mailing list
389-commits@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-commits
[prev in list] [next in list] [prev in thread] [next in thread]