[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-devel-list
Subject:    Re: TBB rebase
From:       Dodji Seketeli <dodji () seketeli ! org>
Date:       2015-01-20 12:04:06
Message-ID: 87vbk1ek09.fsf () seketeli ! org
[Download RAW message or body]

Petr Machata <pmachata@redhat.com> a écrit:

> The soname didn't change.  I reviewed the actual changes using abidiff,
> and the only thing reported that I think is an actual ABI violation is
> insertion of one virtual method.  I don't think that's real however:
>
> 	https://sourceware.org/bugzilla/show_bug.cgi?id=17861

Indeed, the reported insertion of the virtual method is a false positive
resulting from a bug in abidiff.  I have committed a change to abidiff
that should fix that issue now.  And I confirm that the other abi
changes reported by abidiff do not represent ABI-incompatible changes.

> So the current plan is to simply update TBB and not even bump and
> rebuild clients,

Assuming abidiff hasn't forgotten to report any ABI-incompatible change,
this should work, yes.

> but if you could take your packages for a spin with the
> scratch builds, and report back, that would be great.

Good plan.

Cheers.

-- 
		Dodji
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
[prev in list] [next in list] [prev in thread] [next in thread]