[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-buildsys-list
Subject:    Re: [PATCH 2/2] only call python3-pylint in %check if %use_python3 is set
From:       Todd Zullinger <tmz () pobox ! com>
Date:       2017-11-27 15:59:14
Message-ID: 20171127155914.GD3693 () zaya ! teonanacatl ! net
[Download RAW message or body]

Miroslav Suchý wrote:
> Dne 26.11.2017 v 19:45 Todd Zullinger napsal(a):
>>  %check 
>> +%if %{use_python3} 
>>  # ignore the errors for now, just print them and hopefully somebody will fix it one day 
>>  python3-pylint py/mockbuild/ py/*.py py/mockbuild/plugins/* || :
>
> This is not needed, because of that || :

It sends a pointless warning to the output.  Rather than have anyone 
building need to check that the warning is not important, it seems 
better to not run the command where we know it does not exist.

Really, since the el6 branch isn't being merged down from master 
anymore, all the conditions that apply only to newer releases could be 
removed.  But that would be far more change to an old branch, so I 
didn't even consider it seriouly.

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Nothing is wrong with California that a rise in the ocean level
wouldn't cure.
    -- Ross MacDonald (1915-1983)
_______________________________________________
buildsys mailing list -- buildsys@lists.fedoraproject.org
To unsubscribe send an email to buildsys-leave@lists.fedoraproject.org

[prev in list] [next in list] [prev in thread] [next in thread]