[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-buildsys-list
Subject:    Re: Is it a bug of mock?
From:       Clark Williams <clark.williams () gmail ! com>
Date:       2012-01-17 15:56:56
Message-ID: 20120117095656.53c48ad4 () gmail ! com
[Download RAW message or body]

On Tue, 17 Jan 2012 12:25:28 +0000
Kirby Zhou <kirbyzhou@sogou-inc.com> wrote:

> 
> /usr/lib/python2.6/site-packages/mockbuild/uid.py
> mock-1.1.18-1.el6.noarch
> 
> ccache plugin calls changeOwner to take the ownership of ccache directory,
> but why set gid to uid?
> 
> 70     decorate(traceLog())
> 71     def changeOwner(self, path, uid=None, gid=None):
> 72         self._elevatePrivs()
> 73         if uid is None:
> 74             uid = self.unprivUid
> 75         if gid is None:
> 76             gid = uid
> 77         os.chown(path, uid, gid)
> 
> Regards
> Kirby Zhou
> +86 (10) 6272 8261
> 

Kirby,

I'm not sure why the gid was set to the uid (I'm not the original
author of the uid.py code).

Seems more logical to set it to -1 so that it will be unchanged...

Clark
--
buildsys mailing list
buildsys@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys
[prev in list] [next in list] [prev in thread] [next in thread]