[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fedora-buildsys-list
Subject:    Re: [PATCH] Check SELinux state from /selinux/enforce instead of
From:       Ville =?windows-1252?q?Skytt=E4?= <ville.skytta () iki ! fi>
Date:       2010-05-01 20:29:54
Message-ID: 201005012329.55291.ville.skytta () iki ! fi
[Download RAW message or body]

On Monday 26 April 2010, Ville Skyttä wrote:
> On Monday 26 April 2010, Jesse Keating wrote:
> > On Sun, 2010-04-25 at 22:06 +0300, Ville Skyttä wrote:
> > > Any objections to the attached mock patch?
> > 
> > I welcome the bugfix, but that return statement is a little awkward from
> > a pythonic view point.  I would have trouble figuring out wtf it was
> > trying to do if I ran into this code without the context you gave it
> > above.
> 
> Ok, do you find the attached revised version clearer?

I've committed this patch, it can be refined later if need be.
--
buildsys mailing list
buildsys@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/buildsys

[prev in list] [next in list] [prev in thread] [next in thread]