[prev in list] [next in list] [prev in thread] [next in thread]
List: fail2ban-users
Subject: Re: [Fail2ban-users] Complain.conf creates a message with typos and poor spacing. How do I submit a
From: Yehuda Katz <yehuda () ymkatz ! net>
Date: 2015-11-20 19:16:30
Message-ID: CAGBAQ46ViWBbpM=8q4pduKK6df9fVzm5N+90zs4G0s0ooUjG8Q () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
If you think it is something you can fix yourself, make sure you are using
the most up-to-date copy of complain.conf (
https://github.com/fail2ban/fail2ban/blob/master/config/action.d/complain.conf)
and that your mail server or client isn't making any changes to the mail as
it processes it (for example, Microsoft Outlook sometimes removed
whitespace that it thinks is unnecessary which could result in an odd
looking message).
Then you can submit a pull request on GitHub with changes.
- Y
On Fri, Nov 20, 2015 at 12:25 PM, Mark London <mrl@psfc.mit.edu> wrote:
> Hi - How do I submit a bug report for fail2ban? I want to report a
> problem with the email message which is generated by complain.conf
> action. Below is an example of the message it generates.
>
> Note that the first line has a typo. It says "according to a abusix.com
> is on your network".
>
> In the line "This mail was generated by Fail2Ban." There is an
> unnecessary space at the start of the line, and there probably should be
> a line break after that line, to separate it from the next paragraph.
> And I think it should show "was automatically generated". There is no
> line in the email messages, which indicates that the message is
> automatically generated, and I think there should be one.
>
> In that next paragraph, there is an unnecessary line break after
> "https://abusix.com/global-reporting/abuse-contact-db".
>
> --------------------------------------------------------------What the
> present version
> generates----------------------------------------------------
>
> Dear Sir/Madam,
>
> We have detected abuse from the IP address 24.196.73.82, which according
> to a abusix.com is on your network. We would appreciate if you would
> investigate and take action as appropriate.
>
> Log lines are given below, but please ask if you require any further
> information.
>
> (If you are not the correct person to contact about this please accept
> our apologies - your e-mail address was extracted from the whois record
> by an automated process.)
>
> This mail was generated by Fail2Ban.
> The recipient address of this report was provided by the Abuse Contact
> DB by abusix.com. abusix.com does not maintain the content of the
> database. All information which we pass out, derives from the RIR
> databases and is processed for ease of use. If you want to change or
> report non working abuse contacts please contact the appropriate RIR. If
> you have any further question, contact abusix.com directly via email
> (info@abusix.com). Information about the Abuse Contact Database can be
> found here: https://abusix.com/global-reporting/abuse-contact-db
> abusix.com is neither responsible nor liable for the content or accuracy
> of this message.
>
> --------------------------------------What the fixed version should look
> like, IMHO ---------------------------------------
>
> Dear Sir/Madam,
>
> We have detected abuse from the IP address 24.196.73.82, which according
> to abusix.com is on your network. We would appreciate if you would
> investigate and take action as appropriate.
>
> Log lines are given below, but please ask if you require any further
> information.
>
> (If you are not the correct person to contact about this please accept
> our apologies - your e-mail address was extracted from the whois record
> by an automated process.)
>
> This mail was automatically generated by Fail2Ban.
>
> The recipient address of this report was provided by the Abuse Contact
> DB by abusix.com. abusix.com does not maintain the content of the
> database. All information which we pass out, derives from the RIR
> databases and is processed for ease of use. If you want to change or
> report non working abuse contacts please contact the appropriate RIR. If
> you have any further question, contact abusix.com directly via email
> (info@abusix.com). Information about the Abuse Contact Database can be
> found here: https://abusix.com/global-reporting/abuse-contact-db
> abusix.com is neither responsible nor liable for the content or accuracy
> of this message.
>
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Fail2ban-users mailing list
> Fail2ban-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/fail2ban-users
>
[Attachment #5 (text/html)]
<div dir="ltr">If you think it is something you can fix yourself, make sure you are \
using the most up-to-date copy of complain.conf (<a \
href="https://github.com/fail2ban/fail2ban/blob/master/config/action.d/complain.conf"> \
https://github.com/fail2ban/fail2ban/blob/master/config/action.d/complain.conf</a>) \
and that your mail server or client isn't making any changes to the mail as it \
processes it (for example, Microsoft Outlook sometimes removed whitespace that it \
thinks is unnecessary which could result in an odd looking message).<div>Then you can \
submit a pull request on GitHub with changes.<br></div><div><br></div><div>- \
Y</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 20, \
2015 at 12:25 PM, Mark London <span dir="ltr"><<a href="mailto:mrl@psfc.mit.edu" \
target="_blank">mrl@psfc.mit.edu</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi - How do I submit a bug report for fail2ban? I want to \
report a<br> problem with the email message which is generated by complain.conf<br>
action. Below is an example of the message it generates.<br>
<br>
Note that the first line has a typo. It says "according to a <a \
href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a><br> is on \
your network".<br> <br>
In the line "This mail was generated by Fail2Ban." There is an<br>
unnecessary space at the start of the line, and there probably should be<br>
a line break after that line, to separate it from the next paragraph.<br>
And I think it should show "was automatically generated". There is \
no<br> line in the email messages, which indicates that the message is<br>
automatically generated, and I think there should be one.<br>
<br>
In that next paragraph, there is an unnecessary line break after<br>
"<a href="https://abusix.com/global-reporting/abuse-contact-db" rel="noreferrer" \
target="_blank">https://abusix.com/global-reporting/abuse-contact-db</a>".<br> \
<br>
--------------------------------------------------------------What the<br>
present version<br>
generates----------------------------------------------------<br>
<br>
Dear Sir/Madam,<br>
<br>
We have detected abuse from the IP address 24.196.73.82, which according<br>
to a <a href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a> is \
on your network. We would appreciate if you would<br> investigate and take action as \
appropriate.<br> <br>
Log lines are given below, but please ask if you require any further<br>
information.<br>
<br>
(If you are not the correct person to contact about this please accept<br>
our apologies - your e-mail address was extracted from the whois record<br>
by an automated process.)<br>
<br>
This mail was generated by Fail2Ban.<br>
The recipient address of this report was provided by the Abuse Contact<br>
DB by <a href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a>. <a \
href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a> does not \
maintain the content of the<br> database. All information which we pass out, derives \
from the RIR<br> databases and is processed for ease of use. If you want to change \
or<br> report non working abuse contacts please contact the appropriate RIR. If<br>
you have any further question, contact <a href="http://abusix.com" rel="noreferrer" \
target="_blank">abusix.com</a> directly via email<br> (<a \
href="mailto:info@abusix.com">info@abusix.com</a>). Information about the Abuse \
Contact Database can be<br> found here: <a \
href="https://abusix.com/global-reporting/abuse-contact-db" rel="noreferrer" \
target="_blank">https://abusix.com/global-reporting/abuse-contact-db</a><br> <a \
href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a> is neither \
responsible nor liable for the content or accuracy<br> of this message.<br>
<br>
--------------------------------------What the fixed version should look<br>
like, IMHO ---------------------------------------<br>
<br>
Dear Sir/Madam,<br>
<br>
We have detected abuse from the IP address 24.196.73.82, which according<br>
to <a href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a> is on \
your network. We would appreciate if you would<br> investigate and take action as \
appropriate.<br> <br>
Log lines are given below, but please ask if you require any further<br>
information.<br>
<br>
(If you are not the correct person to contact about this please accept<br>
our apologies - your e-mail address was extracted from the whois record<br>
by an automated process.)<br>
<br>
This mail was automatically generated by Fail2Ban.<br>
<br>
The recipient address of this report was provided by the Abuse Contact<br>
DB by <a href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a>. <a \
href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a> does not \
maintain the content of the<br> database. All information which we pass out, derives \
from the RIR<br> databases and is processed for ease of use. If you want to change \
or<br> report non working abuse contacts please contact the appropriate RIR. If<br>
you have any further question, contact <a href="http://abusix.com" rel="noreferrer" \
target="_blank">abusix.com</a> directly via email<br> (<a \
href="mailto:info@abusix.com">info@abusix.com</a>). Information about the Abuse \
Contact Database can be<br> found here: <a \
href="https://abusix.com/global-reporting/abuse-contact-db" rel="noreferrer" \
target="_blank">https://abusix.com/global-reporting/abuse-contact-db</a><br> <a \
href="http://abusix.com" rel="noreferrer" target="_blank">abusix.com</a> is neither \
responsible nor liable for the content or accuracy<br> of this message.<br>
<br>
<br>
------------------------------------------------------------------------------<br>
_______________________________________________<br>
Fail2ban-users mailing list<br>
<a href="mailto:Fail2ban-users@lists.sourceforge.net">Fail2ban-users@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/fail2ban-users" \
rel="noreferrer" target="_blank">https://lists.sourceforge.net/lists/listinfo/fail2ban-users</a><br>
</blockquote></div><br></div>
------------------------------------------------------------------------------
_______________________________________________
Fail2ban-users mailing list
Fail2ban-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fail2ban-users
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic