[prev in list] [next in list] [prev in thread] [next in thread] 

List:       exmh-workers
Subject:    Re: Startup bug in exmh.MASTER
From:       Chris Keane <chris () chris-keane ! co ! uk>
Date:       2001-05-21 9:41:35
[Download RAW message or body]

This is a multipart MIME message.


>>>>> On Fri, 18 May 2001, "BW" = Brent Welch wrote:

  BW> Folks - yet another reminder to try out the mostly-unannounced
  BW> exmh 2.4 that you can get from the standard FTP locations.
  BW> [ ... ]  Any other goodies lurking out there?

Just a very trivial patch, which I posted a while back but doesn't seem
to have been folded in yet.  It fixes colours so that they work better
with light-on-dark colour schemes.

Cheers,
Chris.

[Attachment #3 (message/rfc822)]

This is a multipart MIME message.


I've just been messing around with my exmh colour scheme, and it turns
out that some of the text colours in the folder display are hardwired -
specifically:

  move/copy target - text colour is the default text foreground colour
  unseen folder    - text colour is the default text background colour

This doesn't always work - for example, if you have a light-on-dark colour
scheme, but leave the "target folder" colour as its default yellow, you end
up with target folders being light-on-yellow, which doesn't work.

Patch attached to fix this - does someone with CVS write want to fold it in?

Thanks,
Chris.

["fdisp.patch" (application/x-patch)]

--- fdisp.tcl.old	Fri Jun 23 08:38:48 2000
+++ fdisp.tcl	Fri Oct 20 11:21:54 2000
@@ -95,12 +95,14 @@
     Preferences_Resource fdisp(navbutton)	fl_navbutton 2
     Preferences_Resource fdisp(tarbutton)	fl_tarbutton 3
 
+    Preferences_Resource fdisp(c_fg)		c_foreground black
+    Preferences_Resource fdisp(c_bg)		c_background white
     Preferences_Resource fdisp(c_current)	c_current red
     Preferences_Resource fdisp(c_unseen)	c_unseen  blue
+    Preferences_Resource fdisp(c_unseenBg)	c_unseenBg  $fdisp(c_bg)
     Preferences_Resource fdisp(c_moved)		c_moved   yellow
+    Preferences_Resource fdisp(c_movedFg)	c_movedFg   $fdisp(c_fg)
     Preferences_Resource fdisp(c_popup)		c_popup   wheat
-    Preferences_Resource fdisp(c_fg)		c_foreground black
-    Preferences_Resource fdisp(c_bg)		c_background white
 
     trace variable fdisp(font) w FdispFixupFont
     set fdisp(lastFont) $fdisp(font)
--- fdispColor.tcl.old	Sun Apr  4 21:34:56 1999
+++ fdispColor.tcl	Mon Oct 23 11:40:00 2000
@@ -74,13 +74,13 @@
 	# Let current text be overridden by unseen & target feedback
 	$canvas itemconfigure curtext -fill $fdisp(c_current)
 
-	$canvas itemconfigure unsntext -fill $fdisp(c_bg)
+	$canvas itemconfigure unsntext -fill $fdisp(c_unseenBg)
 	$canvas itemconfigure unsnbox -fill $fdisp(c_unseen)
 	$canvas itemconfigure unsnbox -outline $fdisp(c_unseen) -width 2
 	$canvas itemconfigure unsnbitmap -foreground $fdisp(c_unseen) \
 					-background $fdisp(c_bg)
 
-	$canvas itemconfigure tartext -fill $fdisp(c_fg)
+	$canvas itemconfigure tartext -fill $fdisp(c_movedFg)
 	$canvas itemconfigure tarbox -fill $fdisp(c_moved)
 	$canvas itemconfigure tarbitmap -foreground $fdisp(c_moved) \
 					-background $fdisp(c_bg)


[prev in list] [next in list] [prev in thread] [next in thread]