[prev in list] [next in list] [prev in thread] [next in thread] 

List:       evms-devel
Subject:    Re: [Evms-devel] [aj@andaco.de: Bug#285815: evms: FTBFS (amd64/gcc-4.0): static declaration of 'my_p
From:       Kevin Corry <kevcorry () us ! ibm ! com>
Date:       2004-12-16 17:40:34
Message-ID: 200412161140.34218.kevcorry () us ! ibm ! com
[Download RAW message or body]

On Thursday 16 December 2004 9:37 am, Steve Dobbelstein wrote:
> Matt Zimmerman <mdz@debian.org> wrote on 12/16/2004 02:00:38 AM:
> Rather than making the variables non-static, the variables can be left
> static and the references to them removed from ogfsfsim.h.  No other source
> files use the variables.  The can be left static in fs_ogfs.c.

In this particular situation, you're technically correct. However, convention 
for the plugins is to make EngFncs and my_plugin_record global, since all of 
the LOG macros depend on them. Looking at the ogfs code, it just so happens 
that only that one file uses any LOG macros, but that doesn't necessarily 
need to be the case.

Of course, the ogfs plugin is effectively deprecated, since development on 
ogfs itself has halted in favor of gfs. We could almost remove it from CVS at 
some point in the near future unless we think it could be ported to use gfs 
instead (which I would think is probably unlikely).

-- 
Kevin Corry
kevcorry@us.ibm.com
http://evms.sourceforge.net/


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Evms-devel mailing list
Evms-devel@lists.sourceforge.net
To subscribe/unsubscribe, please visit:
https://lists.sourceforge.net/lists/listinfo/evms-devel
[prev in list] [next in list] [prev in thread] [next in thread]