[prev in list] [next in list] [prev in thread] [next in thread] 

List:       evms-devel
Subject:    [Evms-devel] Re: evms: Expand volume fails to grow underlying	ReiserFS	(segfault)
From:       Steve Dobbelstein <steved () us ! ibm ! com>
Date:       2003-10-22 23:30:04
[Download RAW message or body]


> On Wed, 2003-10-22 at 15:20, Steve Dobbelstein wrote:
>
> > However, the patch mentioned above should enable the reiser EVMS
plug-in to
> > successfully fork and exec resize_reiserfs.  You may want to try that
> > first.
> >
> > Steve D.
>
> Thanks.  Kevin's patch addressed the same issue (I think), though in a
> much different way.  Hopefully you'll soon see the report from the
> list.  Thanks for tracking this down.

Yeah.  Kevin's post landed in my mailbox right after I sent my post.
*sigh*  His patch addressed the same issue of freeing an uninitialized
pointer by initializing the pointer.  My patch addresses it by removing the
call to free the memory.  As mentioned in my post, the reiser EVMS plug-in
shrink code has the same bug.  So if you are going to be testing shrinking
then either apply my patch, which addresses both bugs, or apply the
following patch along with Kevin's patch.

Steve D.

--- evms-2.1.1/plugins/reiser/reiserfs.c  Mon Aug 11 13:27:02 2003
+++ evms-2.1.1-fix/plugins/reiser/reiserfs.c    Wed Oct 22 18:22:55 2003
@@ -920,7 +920,7 @@
                  sector_count_t   * new_size )
 {
      int     rc = 0;
-     char   *argv[7];
+     char   *argv[7] = {NULL};
      pid_t   pidf;
      int     status;
      int     fds1[2];  // pipe for stdin 0=read 1=write





-------------------------------------------------------
This SF.net email is sponsored by OSDN developer relations
Here's your chance to show off your extensive product knowledge
We want to know what you know. Tell us and you have a chance to win $100
http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54
_______________________________________________
Evms-devel mailing list
Evms-devel@lists.sourceforge.net
To subscribe/unsubscribe, please visit:
https://lists.sourceforge.net/lists/listinfo/evms-devel
[prev in list] [next in list] [prev in thread] [next in thread]