[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ethereal-dev
Subject:    Re: [ethereal-dev] Possible bug in packet-ppp.c
From:       "Gilbert Ramirez Jr." <gram () xiexie ! org>
Date:       2000-03-28 17:01:06
[Download RAW message or body]

On Tue, Mar 28, 2000 at 08:34:20AM -0800, Greg Kilfoyle wrote:
> Gilbert Ramirez wrote:
> > 
> > I left the PPPoE dissector as it is, calling dissect_payload_ppp(). If someone
> > has some traces of PPPoE, perhaps they can fiddle with the code to see
> > if its better to call dissect_ppp() now that it takes an offset. The current
> > code is this:
> > 
> >         /* dissect_ppp is apparently done as a 'top level' dissector,
> >                 * so this doesn't work:
> >                 * dissect_ppp(pd,offset+6,fd,tree);
> >                 * Im gonna try fudging it.
> >                 */
> > 
> >         dissect_payload_ppp(pd,offset+6,fd,tree);
> 
> I regularly use ethereal to analyse PPPoE traffic and it decodes fine. I'm not
> sure what you are wanting to try out here. Are you saying that there may be a
> case where the PPP stream has a non-NULL encapsulation? If so, I don't think
> this should occur inside a PPPoE stream, but I suppose it is possible. Anyway,
> if there is something specific you would like me to try, lemme know.

That's fine. Because of the lack of certainty in the comment
("I'm gonna try fudging it"), I wasn't sure if the code was working or not.

thanks,

--gilbert

[prev in list] [next in list] [prev in thread] [next in thread]