[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ethereal-dev
Subject:    Re: [jw@take.net: Re: [ethereal-dev] compilation-error with ethereal
From:       Guy Harris <guy () netapp ! com>
Date:       2000-01-26 22:54:15
[Download RAW message or body]

> I solved the compilation-problem. The reason was my stupidity.
> Some months ago, I patched and installed the libpcap, but I only
> made a silly "make install" and forgot a "make install-incl" so
> the SuSE pcap.h was still placed in /usr/include and wasn=B4t
> overwritten. :-(

But the problem would still show up on systems with the vanilla SuSE
libpcap (and may show up with libpcap 0.5 when it comes out, as I think
they did the same thing), so the change should still go in; I've
attached a patch.

> Sorry for wasting your time

No, you didn't waste our time - you found a real problem in Ethereal,
which we need to fix.

> and sorry for my horrible English too!

It wasn't horrible at all....

(Q: What do you call a person who speaks three languages?

A: Trilingual.

Q: What do you call a person who speaks two languages?

A: Bilingual.

Q. What do you call a person who speaks one language?

A: American.)

["patch" (text/plain)]

Index: capture.c
===================================================================
RCS file: /usr/local/cvsroot/ethereal/capture.c,v
retrieving revision 1.91
diff -c -r1.91 capture.c
*** capture.c	2000/01/23 08:55:30	1.91
--- capture.c	2000/01/26 22:45:46
***************
*** 853,859 ****
       ld->go = FALSE;
    }
    if (ld->pdh) {
!      whdr.ts = phdr->ts;
       whdr.caplen = phdr->caplen;
       whdr.len = phdr->len;
       whdr.pkt_encap = ld->linktype;
--- 853,864 ----
       ld->go = FALSE;
    }
    if (ld->pdh) {
!      /* "phdr->ts" may not necessarily be a "struct timeval" - it may
!         be a "struct bpf_timeval", with member sizes wired to 32
! 	bits - and we may go that way ourselves in the future, so
! 	copy the members individually. */
!      whdr.ts.tv_sec = phdr->ts.tv_sec;
!      whdr.ts.tv_usec = phdr->ts.tv_usec;
       whdr.caplen = phdr->caplen;
       whdr.len = phdr->len;
       whdr.pkt_encap = ld->linktype;


[prev in list] [next in list] [prev in thread] [next in thread]